You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preserve tolerant template placeholders while making missing configured AI inputs fail with a clear error.
Serialize structured template and extraction values as JSON.
Behavior note
ai_agent previously skipped unresolved configured inputs and could run with a partial or empty prompt. It now fails the node before starting an LLM call. Present null values remain valid inputs.
Tests
go test ./internal/services
go test ./... after satisfying the required frontend/dist embed input
This PR includes focused public unit coverage. Test placement is also being discussed in #193; I am happy to adapt it to the maintainers preferred convention.
ctx.Item is populated only inside iterator execution; ctx.Actor is never populated. A production-shaped
diagnostic using Event.ItemID=42 and EffectiveActorID=7 reproduced:
item.id -> (, false)
user.id -> (, false)
This is user-visible because the editor explicitly suggests item.id, item.status, and item.priority, while
buildAIAgentUserMessage
(
return"", fmt.Errorf("input field %q not found in execution context", field)
}
)
now hard-fails when any configured input is missing. Valid editor-created agent actions therefore abort
before invoking the LLM.
The context should be hydrated from the event/effective actor, or the resolver should fall back through the
repositories and event IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai_extract, andai_agent.item.*inputs, nested output paths, slices, trigger data, prior values, users, and SCM payloads.Behavior note
ai_agentpreviously skipped unresolved configured inputs and could run with a partial or empty prompt. It now fails the node before starting an LLM call. Present null values remain valid inputs.Tests
go test ./internal/servicesgo test ./...after satisfying the requiredfrontend/distembed inputThis PR includes focused public unit coverage. Test placement is also being discussed in #193; I am happy to adapt it to the maintainers preferred convention.