In nbd/config.go there are 3 handwritten functions defined (isTrue, isFalse and isTrueFalse) that all seem to serve the purpose as what strconv.ParseBool. Could it be possible to remove the custom code (and thus avoid having to maintain that), and replace it with the standard Golang (and idiomatic) approach?
Where isFalse is used you would have to simply negate the bool result in a non-error case (!result). Where isTrueFalse you would use in a non-error case the result bool param directly where now the first result param is used, and you would use the negated version (!result) of that bool param where you now use the second result param is used.
Or is there a special reason that I'm missing that would explain why you would write custom code for this?
In
nbd/config.gothere are 3 handwritten functions defined (isTrue, isFalse and isTrueFalse) that all seem to serve the purpose as what strconv.ParseBool. Could it be possible to remove the custom code (and thus avoid having to maintain that), and replace it with the standard Golang (and idiomatic) approach?Where isFalse is used you would have to simply negate the bool result in a non-error case (
!result). Where isTrueFalse you would use in a non-error case theresultbool param directly where now the first result param is used, and you would use the negated version (!result) of that bool param where you now use the second result param is used.Or is there a special reason that I'm missing that would explain why you would write custom code for this?