feat: check exported symbols on macOS - #237
Merged
Merged
Conversation
lidavidm
force-pushed
the
symbols-macos
branch
from
August 11, 2026 08:11
430806e to
ff5de30
Compare
lidavidm
force-pushed
the
symbols-macos
branch
2 times, most recently
from
August 12, 2026 00:24
dda714f to
5934f30
Compare
lidavidm
force-pushed
the
symbols-macos
branch
2 times, most recently
from
August 12, 2026 00:47
6f8733e to
db907c9
Compare
There was a problem hiding this comment.
Pull request overview
Adds macOS exported-symbol validation alongside existing Linux checks.
Changes:
- Adds macOS symbol extraction and shared export validation.
- Separates manylinux and macOS deployment-target checks.
- Updates unit tests for the refactored checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
adbc_drivers_dev/make_checks.py |
Implements macOS symbol validation and refactors platform checks. |
tests/test_make_checks.py |
Updates tests for symbol extraction and validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
This works, but the build will fail since the build scripts don't actually hide symbols on macOS. |
lidavidm
force-pushed
the
symbols-macos
branch
from
August 12, 2026 02:51
33e917f to
84b9682
Compare
lidavidm
marked this pull request as ready for review
August 12, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Validate that only Adbc* symbols are exported on macOS, same as we do on Linux.
Assisted-by: GPT-5.6 Sol codex@openai.com