diff --git a/src/aether-miscpp/serialization/details/serialization_result.h b/src/aether-miscpp/serialization/details/serialization_result.h index cc7a150..c2f915c 100644 --- a/src/aether-miscpp/serialization/details/serialization_result.h +++ b/src/aether-miscpp/serialization/details/serialization_result.h @@ -57,11 +57,14 @@ class Result { using value_type = seri::Good; using error_type = seri::SeriError; - // NOLINTNEXTLINE - constexpr Result(Ok&&) noexcept : ok_{true} {} - // NOLINTNEXTLINE + // NOLINTNEXTLINE(*explicit*,*rvalue*) + constexpr Result(Ok&& ok_val) noexcept : ok_{true} { + // explicitly discard value + (void)ok_val; + } + // NOLINTNEXTLINE(*explicit*) constexpr Result(Error&& err) noexcept - : ok_{false}, error_{std::move(err.error)} {} + : ok_{false}, error_{std::move(err).error} {} // since SeriError is trivially destructible Result destructor is default static_assert(std::is_trivially_destructible_v,