Burn down golang.org/x/tools/cmd/deadcode linting violations

[timflannagan]

Manually run locally:

$ go run golang.org/x/tools/cmd/deadcode@latest -tags integration,e2e -test ./...
internal/cli/common/deployments.go:73:6: unreachable func: FindDeploymentByIDPrefix
internal/cli/common/deployments.go:147:6: unreachable func: DeploymentResourceName
internal/cli/common/docker/docker.go:21:6: unreachable func: NewExecutor
internal/cli/common/docker/docker.go:29:20: unreachable func: Executor.CheckAvailability
internal/cli/common/docker/docker.go:44:20: unreachable func: Executor.Run
internal/cli/common/docker/docker.go:72:20: unreachable func: Executor.Build
internal/cli/common/docker/docker.go:84:20: unreachable func: Executor.Push
internal/cli/common/docker/docker.go:93:6: unreachable func: ComposeCommand
internal/cli/common/docker/docker.go:105:20: unreachable func: Executor.ImageExistsLocally
internal/cli/common/docker/docker.go:111:20: unreachable func: Executor.Pull
internal/cli/common/docker/docker.go:122:20: unreachable func: Executor.CreateContainer
internal/cli/common/docker/docker.go:141:20: unreachable func: Executor.CopyFromContainer
internal/cli/common/docker/docker.go:157:20: unreachable func: Executor.RemoveContainer
internal/cli/declarative/build.go:216:6: unreachable func: CheckDockerAvailable
internal/cli/declarative/extension.go:27:6: unreachable func: RegisterExtensionKind
internal/cli/mcp/manifest/manager.go:119:19: unreachable func: Manager.Save
internal/cli/mcp/manifest/manager.go:125:19: unreachable func: Manager.AddTool
internal/cli/mcp/manifest/manager.go:143:19: unreachable func: Manager.RemoveTool
internal/cli/mcp/manifest/manager.go:157:6: unreachable func: GetDefault
internal/cli/mcp/manifest/manager.go:186:6: unreachable func: getFrameworkRuntimeConfig
internal/client/client.go:69:6: unreachable func: NewClientWithConfig
internal/registry/runtimes/utils/deployment_adapter_utils.go:490:6: unreachable func: EnvMapToStringSlice
internal/registry/service/deployment/errors.go:34:6: unreachable func: IsUnsupportedDeploymentRuntimeError
pkg/api/v1alpha1/doc.go:43:6: unreachable func: RegisterPlural
pkg/api/v1alpha1/doc.go:48:6: unreachable func: MustRegisterPlural
pkg/api/v1alpha1/kinds.go:53:6: unreachable func: WithPlural
pkg/api/v1alpha1/kinds.go:198:24: unreachable func: KindRegistry.UpdatePlural
pkg/api/v1alpha1/scheme.go:132:6: unreachable func: IsContentRegistryKind
pkg/cli/db/migrate/registry.go:45:6: unreachable func: Register
pkg/cli/db/migrate/registry.go:71:6: unreachable func: ResetForTesting
pkg/printer/table.go:114:6: unreachable func: PrintTable
pkg/registry/auth/system.go:8:25: unreachable func: SystemSession.Principal
pkg/registry/auth/system.go:13:6: unreachable func: IsSystemSession
pkg/registry/auth/system.go:19:6: unreachable func: WithSystemContext
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:16:6: unreachable func: Stringify
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:145:6: unreachable func: Parse
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:207:6: unreachable func: revive
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:225:6: unreachable func: loop
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:247:6: unreachable func: ref
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:260:6: unreachable func: ToJSON
ui/node_modules/flatted/golang/pkg/flatted/flatted.go:271:6: unreachable func: FromJSON

We only care about the internal/ package for now. Anything in pkg/ should be audited as well. Not sure why deadcode is highlighting the ui/node_modules though.

[github-actions]

This issue has been marked as stale due to no activity in the last 60 days. It will be closed in 14 days unless it is tagged "no stalebot" or other activity occurs.