From 05270221f935bc1239cdccbbef42ed4b04a04c3d Mon Sep 17 00:00:00 2001 From: Pablo Garcia Date: Fri, 14 Aug 2026 17:55:58 +0200 Subject: [PATCH] drop stale ENABLE_REGISTRY_VALIDATION env var The OSS Helm chart, the chart unit tests, the local docker-compose, and .env.example still rendered AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION as an active knob, but the current server config no longer reads it. Registry validation is now controlled by types.AppOptions.RegistryValidator. Removes: - config.enableRegistryValidation (values.yaml + README.md table) - AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION (configmap.yaml template, docker-compose.yml, .env.example) - chart unit test that asserted the removed env var Refs issue #566. Pure deletion, no behavior change for callers already on the AppOptions.RegistryValidator path. --- .env.example | 4 ---- charts/agentregistry/README.md | 1 - charts/agentregistry/templates/configmap.yaml | 1 - charts/agentregistry/tests/configmap_test.yaml | 6 ------ charts/agentregistry/values.yaml | 2 -- docker/docker-compose.yml | 2 -- 6 files changed, 16 deletions(-) diff --git a/.env.example b/.env.example index fff05852..3835913b 100644 --- a/.env.example +++ b/.env.example @@ -10,10 +10,6 @@ AGENT_REGISTRY_DATABASE_URL=postgres://localhost:5432/agentregistry?sslmode=disa # Set automatically during build, can be overridden for development AGENT_REGISTRY_VERSION=dev -# Registry Validation -# Enable validation of registry package references -AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION=false - # MCP Registry v0.1 Compatibility (read-only) # Re-exposes MCPServer resources in the official server.json shape at # /v0.1/servers so registry-aware clients (e.g. VS Code's MCP gallery) can diff --git a/charts/agentregistry/README.md b/charts/agentregistry/README.md index 1eb17394..78c398ca 100644 --- a/charts/agentregistry/README.md +++ b/charts/agentregistry/README.md @@ -129,7 +129,6 @@ This creates a `Role`/`RoleBinding` in each listed namespace (plus the installat | commonAnnotations | object | `{}` | Annotations to add to all deployed resources | | commonLabels | object | `{}` | Labels to add to all deployed resources | | config.agentRegistryMcpPort | string | `"31313"` | Agent Registry MCP server port | -| config.enableRegistryValidation | string | `"false"` | Enable input validation on the registry API | | config.serverAddress | string | `":8080"` | Listen address for the HTTP server | | containerSecurityContext.allowPrivilegeEscalation | bool | `false` | Allow privilege escalation | | containerSecurityContext.capabilities.drop | list | `["ALL"]` | Linux capabilities to drop | diff --git a/charts/agentregistry/templates/configmap.yaml b/charts/agentregistry/templates/configmap.yaml index 70e00037..be46a3c6 100644 --- a/charts/agentregistry/templates/configmap.yaml +++ b/charts/agentregistry/templates/configmap.yaml @@ -13,4 +13,3 @@ metadata: data: AGENT_REGISTRY_SERVER_ADDRESS: {{ .Values.config.serverAddress | quote }} AGENT_REGISTRY_MCP_PORT: {{ .Values.config.agentRegistryMcpPort | quote }} - AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION: {{ .Values.config.enableRegistryValidation | quote }} diff --git a/charts/agentregistry/tests/configmap_test.yaml b/charts/agentregistry/tests/configmap_test.yaml index 45f3f8b6..acd27055 100644 --- a/charts/agentregistry/tests/configmap_test.yaml +++ b/charts/agentregistry/tests/configmap_test.yaml @@ -43,12 +43,6 @@ tests: path: data.AGENT_REGISTRY_MCP_PORT value: "31313" - - it: sets AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION - asserts: - - equal: - path: data.AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION - value: "false" - - it: overrides serverAddress set: config.serverAddress: ":9090" diff --git a/charts/agentregistry/values.yaml b/charts/agentregistry/values.yaml index ad022349..58ad4799 100644 --- a/charts/agentregistry/values.yaml +++ b/charts/agentregistry/values.yaml @@ -45,8 +45,6 @@ config: serverAddress: ":8080" # -- Agent Registry MCP server port agentRegistryMcpPort: "31313" - # -- Enable input validation on the registry API - enableRegistryValidation: "false" # @section Deployment parameters diff --git a/docker/docker-compose.yml b/docker/docker-compose.yml index 3896c8c6..ddb38165 100644 --- a/docker/docker-compose.yml +++ b/docker/docker-compose.yml @@ -42,8 +42,6 @@ services: environment: AGENT_REGISTRY_DATABASE_URL: "postgres://agentregistry:agentregistry@postgres:5432/agentregistry?sslmode=disable" AGENT_REGISTRY_SERVER_ADDRESS: ":8080" - # Temporarily only for local development. - AGENT_REGISTRY_ENABLE_REGISTRY_VALIDATION: "false" AGENT_REGISTRY_MCP_PORT: "31313" KUBECONFIG: "/root/.kube/config" ports: