From 0368c843bcd3755e19ad7010ee76c3390ac4ae2f Mon Sep 17 00:00:00 2001 From: Jarek Potiuk Date: Sat, 29 Aug 2026 19:20:12 -0500 Subject: [PATCH] fix(_template): drop Apache Airflow residue from the templates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `_template` scaffolds are meant to be project-agnostic — an adopter copies them and fills in placeholders. Four spots still carried the framework's original adopter's specifics as if they were generic: - `reviewer-roster.md`: the "shape per entry" sample used `airflow/jobs/` as its path-prefix example, unmarked, and the Notes section repeated it. Now `src/scheduler/`, which reads as a shape rather than as one project's tree. - `security-intake-config.md`: the ASF defaults were described as reproducing "the Apache Airflow security-team workflow". They reproduce the standard ASF one; naming a single project made the sentence look like a calibration an adopter had to match. - `pr-management-quick-merge-config.md`: the `tier_b_allow_globs` default shipped `**/example_dags/**`, which is meaningful only in an Airflow tree. Replaced with `**/examples/**` + `**/example_*/**` — generic, and a superset of the old glob, so an Airflow adopter's example-DAG PRs stay in tier B. The prose above the globs no longer describes the default set as Airflow-shaped. - `candidate-rules.md`: the skill's built-in default list carries the same globs, updated in lock-step so template and skill do not drift. Deliberately left alone: every spot that already marks itself as an example — the `release-management-config.md` "filled example" section, the `mentoring-welcome-config.md` filled-in block, and the `Example: apache/airflow-...` cells. Those are calibration aids, not residue. Generated-by: Claude Code (Claude Opus 5) --- projects/_template/pr-management-quick-merge-config.md | 5 +++-- projects/_template/reviewer-roster.md | 4 ++-- projects/_template/security-intake-config.md | 2 +- skills/pr-management-quick-merge/candidate-rules.md | 3 ++- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/projects/_template/pr-management-quick-merge-config.md b/projects/_template/pr-management-quick-merge-config.md index 5aa60d23c..b8a34ba68 100644 --- a/projects/_template/pr-management-quick-merge-config.md +++ b/projects/_template/pr-management-quick-merge-config.md @@ -48,7 +48,7 @@ skill. This is the **`_template` default**; new adopters copy it into their own `/pr-management-quick-merge-config.md` and tune the thresholds and path globs for their repository layout. -The default globs below are shaped for an Apache-Airflow-like monorepo; an +The default globs below are shaped for a Python monorepo; an adopter with a different layout replaces them wholesale. When a field is absent, the skill falls back to the default noted in its row. @@ -95,7 +95,8 @@ spelling_wordlist.txt **/tests/** **/test_*.py **/*_test.py -**/example_dags/** +**/examples/** +**/example_*/** ``` ### `deny_globs` — absolute disqualifiers (consequential areas; one match drops the PR even at one line) diff --git a/projects/_template/reviewer-roster.md b/projects/_template/reviewer-roster.md index f2e268aae..5f073de8c 100644 --- a/projects/_template/reviewer-roster.md +++ b/projects/_template/reviewer-roster.md @@ -30,7 +30,7 @@ Shape per entry: - handle: github-login # GitHub @handle (required) areas: # list of areas / path prefixes / labels - component:scheduler - - airflow/jobs/ + - src/scheduler/ max_reviews: 5 # optional; default 5 --> @@ -48,7 +48,7 @@ Shape per entry: ## Notes - `areas` entries may be component labels (e.g. `component:scheduler`), - path prefixes (e.g. `airflow/jobs/`), or free-form area names that + path prefixes (e.g. `src/scheduler/`), or free-form area names that match the labels used in this project's issue tracker. - `max_reviews` is the maximum number of open review requests this reviewer is comfortable holding simultaneously. When their current diff --git a/projects/_template/security-intake-config.md b/projects/_template/security-intake-config.md index 6aeb32d48..23b58caec 100644 --- a/projects/_template/security-intake-config.md +++ b/projects/_template/security-intake-config.md @@ -42,7 +42,7 @@ authoritative home for those values. This file does two things: New adopters: copy this file into your own `/security-intake-config.md` and replace every `TODO`. -The ASF defaults reproduce the Apache Airflow security-team workflow +The ASF defaults reproduce the standard ASF security-team workflow unchanged; override only the fields that differ for your project. Related scaffolds in the same adopter directory: diff --git a/skills/pr-management-quick-merge/candidate-rules.md b/skills/pr-management-quick-merge/candidate-rules.md index 15cf7b651..f3a5a6ff6 100644 --- a/skills/pr-management-quick-merge/candidate-rules.md +++ b/skills/pr-management-quick-merge/candidate-rules.md @@ -190,7 +190,8 @@ tier_b_allow_globs: - "**/tests/**" - "**/test_*.py" - "**/*_test.py" - - "**/example_dags/**" + - "**/examples/**" + - "**/example_*/**" deny_globs: # absolute disqualifiers, even at one line - "**/migrations/**"