From 00dc42922cd7bcc7c78b45ad95497330744e56bb Mon Sep 17 00:00:00 2001 From: Augment Agent Date: Fri, 1 May 2026 22:02:52 +0000 Subject: [PATCH] polish(creacc): drop dead transient-failure path (#14) After replacing the COBOL ENQ/DEQ with SELECT ... FOR UPDATE on control, the CreaccResult.isTransientFailure() predicate (and the CreaccController 503 mapping that consumed it) became unreachable. CreaccService and CreaccRepository only emit fail codes A, 1, 8, 9, and 7 (rollback) - never 3 or 5. Drop the dead predicate and the unused TRANSIENT_FAIL_CODES constant, and remove the matching 503 branch from CreaccController#failureStatus. Counter / lock contention is already either retried by CrdbRetry on 40001 or surfaced as CbsaAbendException -> 500. --- src/main/java/com/augment/cbsa/domain/CreaccResult.java | 5 ----- .../java/com/augment/cbsa/web/creacc/CreaccController.java | 3 --- 2 files changed, 8 deletions(-) diff --git a/src/main/java/com/augment/cbsa/domain/CreaccResult.java b/src/main/java/com/augment/cbsa/domain/CreaccResult.java index 20bbeeb..12cfba7 100644 --- a/src/main/java/com/augment/cbsa/domain/CreaccResult.java +++ b/src/main/java/com/augment/cbsa/domain/CreaccResult.java @@ -13,7 +13,6 @@ public record CreaccResult( private static final Set VALIDATION_FAIL_CODES = Set.of("A"); private static final Set NOT_FOUND_FAIL_CODES = Set.of("1"); private static final Set CAPACITY_FAIL_CODES = Set.of("8"); - private static final Set TRANSIENT_FAIL_CODES = Set.of("3", "5"); public CreaccResult { Objects.requireNonNull(failCode, "failCode must not be null"); @@ -51,8 +50,4 @@ public boolean isNotFoundFailure() { public boolean isCapacityFailure() { return !creationSuccess && CAPACITY_FAIL_CODES.contains(failCode); } - - public boolean isTransientFailure() { - return !creationSuccess && TRANSIENT_FAIL_CODES.contains(failCode); - } } \ No newline at end of file diff --git a/src/main/java/com/augment/cbsa/web/creacc/CreaccController.java b/src/main/java/com/augment/cbsa/web/creacc/CreaccController.java index bb13d06..ff4d644 100644 --- a/src/main/java/com/augment/cbsa/web/creacc/CreaccController.java +++ b/src/main/java/com/augment/cbsa/web/creacc/CreaccController.java @@ -66,9 +66,6 @@ private HttpStatus failureStatus(CreaccResult result) { if (result.isCapacityFailure()) { return HttpStatus.CONFLICT; } - if (result.isTransientFailure()) { - return HttpStatus.SERVICE_UNAVAILABLE; - } return HttpStatus.INTERNAL_SERVER_ERROR; }