From ba27307d598f9ceee3da9e730c1cc8f66031a51e Mon Sep 17 00:00:00 2001 From: Vysakh Menon Date: Thu, 20 Aug 2026 09:59:12 -0700 Subject: [PATCH 1/3] 34531 schema updates for correction --- python/common/business-registry-model/poetry.lock | 8 ++++---- python/common/business-registry-model/pyproject.toml | 4 ++-- .../src/business_model/models/court_order.py | 7 +++++-- .../src/business_model/models/document.py | 1 + 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/python/common/business-registry-model/poetry.lock b/python/common/business-registry-model/poetry.lock index 75e790e0f6..dd3bf34abc 100644 --- a/python/common/business-registry-model/poetry.lock +++ b/python/common/business-registry-model/poetry.lock @@ -1472,7 +1472,7 @@ rpds-py = ">=0.7.0" [[package]] name = "registry_schemas" -version = "2.18.79" +version = "2.18.77" description = "A short description of the project" optional = false python-versions = ">=3.6" @@ -1490,8 +1490,8 @@ strict-rfc3339 = "*" [package.source] type = "git" url = "https://github.com/bcgov/business-schemas.git" -reference = "2.18.79" -resolved_reference = "40080a9b693e0090fae08db377baf94e34cb7588" +reference = "2.18.80" +resolved_reference = "c72eb2a6dd89fc6ffefbbdc1af269b72d0eaf38c" [[package]] name = "requests" @@ -2085,4 +2085,4 @@ files = [ [metadata] lock-version = "2.1" python-versions = ">=3.13,<3.14" -content-hash = "cbfd22a623d7291fc842721b790e7b7bc8fce33af5ecf74c78821fd9c78df3a3" +content-hash = "e62773b60709314e5387dce56e1a8341160e8489f1059a89f65fdfddd0aeb81c" diff --git a/python/common/business-registry-model/pyproject.toml b/python/common/business-registry-model/pyproject.toml index d92149fad2..f82f29650a 100644 --- a/python/common/business-registry-model/pyproject.toml +++ b/python/common/business-registry-model/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "business-model" -version = "3.4.8" +version = "3.4.9" description = "" authors = [ {name = "thor",email = "1042854+thorwolpert@users.noreply.github.com"} @@ -9,7 +9,7 @@ readme = "README.md" requires-python = ">=3.13,<3.14" dependencies = [ "sql-versioning @ git+https://github.com/bcgov/lear.git@main#subdirectory=python/common/sql-versioning-alt", - "registry-schemas @ git+https://github.com/bcgov/business-schemas.git@2.18.79", + "registry-schemas @ git+https://github.com/bcgov/business-schemas.git@2.18.80", "flask-migrate (>=4.1.0,<5.0.0)", "pg8000 (>=1.31.2,<2.0.0)", "pydantic (>=2.10.6,<3.0.0)", diff --git a/python/common/business-registry-model/src/business_model/models/court_order.py b/python/common/business-registry-model/src/business_model/models/court_order.py index 25c9a5c3bd..565a35e533 100644 --- a/python/common/business-registry-model/src/business_model/models/court_order.py +++ b/python/common/business-registry-model/src/business_model/models/court_order.py @@ -58,14 +58,17 @@ class CourtOrder(db.Model, Versioned): @property def json(self) -> dict: - return { + data = { "id": self.id, "filingId": self.filing_id, "fileNumber": self.file_number, - "orderDate": self.order_date, "effectOfOrder": self.effect_of_order, "orderDetails": self.order_details } + if self.order_date: + data["orderDate"] = self.order_date.isoformat() + + return data def save(self): db.session.add(self) diff --git a/python/common/business-registry-model/src/business_model/models/document.py b/python/common/business-registry-model/src/business_model/models/document.py index ad4c03a4dd..3af5c099c8 100644 --- a/python/common/business-registry-model/src/business_model/models/document.py +++ b/python/common/business-registry-model/src/business_model/models/document.py @@ -36,6 +36,7 @@ class DocumentType(Enum): COOP_MEMORANDUM = 'coop_memorandum' COURT_ORDER = 'court_order' DIRECTOR_AFFIDAVIT = 'director_affidavit' + SUPPORTING_DOCUMENT = 'supporting_document' class Document(db.Model, Versioned): From 646cd65f1bfb57994a83d7ef40a73f11cfb6766c Mon Sep 17 00:00:00 2001 From: Vysakh Menon Date: Thu, 20 Aug 2026 10:02:04 -0700 Subject: [PATCH 2/3] no message --- python/common/business-registry-model/poetry.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/common/business-registry-model/poetry.lock b/python/common/business-registry-model/poetry.lock index dd3bf34abc..f18140d365 100644 --- a/python/common/business-registry-model/poetry.lock +++ b/python/common/business-registry-model/poetry.lock @@ -1472,7 +1472,7 @@ rpds-py = ">=0.7.0" [[package]] name = "registry_schemas" -version = "2.18.77" +version = "2.18.80" description = "A short description of the project" optional = false python-versions = ">=3.6" From 92f258e44c81fc3c6e79b4c92481c796a227e397 Mon Sep 17 00:00:00 2001 From: Vysakh Menon Date: Thu, 20 Aug 2026 10:07:39 -0700 Subject: [PATCH 3/3] no message --- .../business-registry-model/tests/models/test_court_order.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/python/common/business-registry-model/tests/models/test_court_order.py b/python/common/business-registry-model/tests/models/test_court_order.py index af82ddb33e..fafcd9ba73 100644 --- a/python/common/business-registry-model/tests/models/test_court_order.py +++ b/python/common/business-registry-model/tests/models/test_court_order.py @@ -44,7 +44,6 @@ def test_court_order_json(session): """Assert that court order json property works.""" business = factory_business('CP1234567') filing = factory_filing(business, data_dict={'filing': {'header': {'name': 'courtOrder'}}}) - from datetime import timezone order_date = datetime.now(UTC) court_order = CourtOrder( @@ -61,7 +60,7 @@ def test_court_order_json(session): assert co_json['id'] == court_order.id assert co_json['filingId'] == filing.id assert co_json['fileNumber'] == '12345' - assert co_json['orderDate'] == order_date + assert co_json['orderDate'] == order_date.isoformat() assert co_json['effectOfOrder'] == 'planOfArrangement' assert co_json['orderDetails'] == 'Some details'