Skip to content

[zenith] chore: enforce submodule notes for every gitlink #116

Description

@bigduu

Context

Independent review of #115 found that Validate Submodule Pointers dynamically discovers all changed mode-160000 paths, but Require Submodule Notes (PR) uses a static watched set containing only .gitmodules, bamboo, bodhi, and lotus. A future pointer-only update for Jiandu, Nova, Lotus Next, Magpie, Pavilion, or Bodhi Server can therefore bypass the required ## Submodule Updates notes when .gitmodules is unchanged.

This is a pre-existing P3 workflow-hardening gap and is intentionally separate from #114.

Acceptance criteria

  • Detect changed gitlinks dynamically rather than maintaining a partial static path allowlist.
  • Require a concrete ## Submodule Updates section for every added, removed, or updated gitlink.
  • Keep the edited PR event behavior so correcting the PR body reruns the gate.
  • Add regression coverage for a pointer-only change to jiandu and at least one other currently omitted submodule.
  • Preserve the existing no-submodule-change fast path.

Non-goals

  • No submodule pointer changes.
  • No release-train changes.
  • No Jiandu source changes.

Found during independent review of #115.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:P3Low — when possibletype:infraInfrastructure, CI/CD, deployment

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions