From e2c1bef16348eb389f6ae352d8ad489819dddd72 Mon Sep 17 00:00:00 2001
From: Collins Ikechukwu <collinschristroa@gmail.com>
Date: Sun, 5 Jul 2026 13:59:49 +0100
Subject: [PATCH] fix(bounty): derive shortlist selection from live application
 list

Declining a checked application unmounted its checkbox but left its id in
the checked set, so the sticky-bar count stayed inflated and Approve
shortlist submitted a DECLINED application. Filter the selection against
the current SUBMITTED rows so the count and the payload only ever include
actionable applications.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 .../bounties/manage/BountyApplicationsPanel.tsx  | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/components/organization/bounties/manage/BountyApplicationsPanel.tsx b/components/organization/bounties/manage/BountyApplicationsPanel.tsx
index e7229a8e..eebf109e 100644
--- a/components/organization/bounties/manage/BountyApplicationsPanel.tsx
+++ b/components/organization/bounties/manage/BountyApplicationsPanel.tsx
@@ -104,6 +104,14 @@ export default function BountyApplicationsPanel({
     a.applicationStatus === 'SUBMITTED';
   const busy = select.isPending || shortlist.isPending || decline.isPending;
 
+  // `checked` can hold ids that have since left SUBMITTED (e.g. a checked
+  // application was declined, unmounting its checkbox), so derive the
+  // effective selection from the live list: the sticky-bar count and the
+  // shortlist payload must never include a non-actionable application.
+  const selectedIds = [...checked].filter(id =>
+    applications.some(a => a.id === id && actionable(a))
+  );
+
   const toggleCheck = (id: string) =>
     setChecked(prev => {
       const next = new Set(prev);
@@ -122,7 +130,7 @@ export default function BountyApplicationsPanel({
     );
 
   const onShortlist = () => {
-    const applicationIds = [...checked];
+    const applicationIds = selectedIds;
     if (
       overview.shortlistSize != null &&
       applicationIds.length > overview.shortlistSize
@@ -171,19 +179,19 @@ export default function BountyApplicationsPanel({
       {isCompetition && (
         <div className='sticky bottom-4 flex items-center justify-between gap-3 rounded-2xl border border-zinc-800 bg-zinc-950/90 p-4 backdrop-blur'>
           <span className='text-sm text-zinc-400'>
-            {checked.size} selected
+            {selectedIds.length} selected
             {overview.shortlistSize != null
               ? ` (max ${overview.shortlistSize})`
               : ''}
           </span>
           <BoundlessButton
-            disabled={checked.size === 0 || busy}
+            disabled={selectedIds.length === 0 || busy}
             onClick={onShortlist}
           >
             {shortlist.isPending ? (
               <Loader2 className='h-4 w-4 animate-spin' />
             ) : (
-              `Approve shortlist (${checked.size})`
+              `Approve shortlist (${selectedIds.length})`
             )}
           </BoundlessButton>
         </div>