Skip to content

AnswerRelevancy uses model parameter instead of embedding_model for Embedding call #166

Description

Hi there,
just found a possible bug. The AnswerRelevancy scorer allows to pass an embedding_model parameter, which is used in the EmbeddingSimilarity call of the async runner, but not in the synchronous version, leading to wrong model usage when using the scorer synchronously.

EmbeddingSimilarity(client=self.client).eval_async(
    output=q["question"], expected=input, model=self.embedding_model
)

vs.

EmbeddingSimilarity(client=self.client).eval(output=q["question"], expected=input, model=self.model)

created a PR: #167

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions