From cf66e9dcb7c42498c85be7bacf1154420e3393d8 Mon Sep 17 00:00:00 2001
From: Noah Treuhaft <noah.treuhaft@gmail.com>
Date: Wed, 26 Aug 2026 17:32:16 -0400
Subject: [PATCH] compiler/semantic: fix duplicate field panic

Fix panic on "select 1 as a, 2 as a, 3 as a_1" caused by attempting to
create a record with two fields named a_1.
---
 compiler/semantic/sql.go              | 18 +++++++++++++-----
 compiler/ztests/sql/as-duplicate.yaml |  4 ++--
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/compiler/semantic/sql.go b/compiler/semantic/sql.go
index acc3c0471e..16e1e18ed9 100644
--- a/compiler/semantic/sql.go
+++ b/compiler/semantic/sql.go
@@ -718,12 +718,20 @@ func (t *translator) resolveOrdinalOuter(ts tableScope, n ast.Node, prefix strin
 }
 
 func dedup(scores map[string]int, s string) string {
-	cnt := scores[s]
-	scores[s] = cnt + 1
-	if cnt != 0 {
-		s = fmt.Sprintf("%s_%d", s, cnt)
+	score, ok := scores[s]
+	if !ok {
+		scores[s] = 0
+		return s
+	}
+	for {
+		score++
+		s2 := fmt.Sprintf("%s_%d", s, score)
+		if _, ok := scores[s2]; !ok {
+			scores[s] = score
+			scores[s2] = 0
+			return s2
+		}
 	}
-	return s
 }
 
 func valuesExpr(e sem.Expr, seq sem.Seq) sem.Seq {
diff --git a/compiler/ztests/sql/as-duplicate.yaml b/compiler/ztests/sql/as-duplicate.yaml
index 49178b973e..adaaa25cf9 100644
--- a/compiler/ztests/sql/as-duplicate.yaml
+++ b/compiler/ztests/sql/as-duplicate.yaml
@@ -1,7 +1,7 @@
 script: |
-  super -s -c 'SELECT 1 as foo, 2 as foo'
+  super -s -c 'SELECT 1 as a, 2 as a, 3 as a_1, 4 as a_1, 5 as a_2, 6 as a, 7 as a_2'
 
 outputs:
   - name: stdout
     data: |
-      {foo:1,foo_1:2}
+      {a:1,a_1:2,a_1_1:3,a_1_2:4,a_2:5,a_3:6,a_2_1:7}