From 395ca657a9558bdd9a2a9761d4f56c8d8cef7e35 Mon Sep 17 00:00:00 2001 From: Noah Treuhaft Date: Wed, 26 Aug 2026 19:55:50 -0400 Subject: [PATCH] sio/parquetio: simplify NewReader --- sio/parquetio/reader.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sio/parquetio/reader.go b/sio/parquetio/reader.go index 24eb17cc6..8e03128e5 100644 --- a/sio/parquetio/reader.go +++ b/sio/parquetio/reader.go @@ -55,15 +55,10 @@ func NewReader(ctx context.Context, sctx *super.Context, r io.Reader, p sbuf.Pus if err != nil { return nil, err } - prmd := pr.MetaData() pqprops := pqarrow.ArrowReadProperties{ Parallel: true, BatchSize: 16184, } - schemaManifest, err := pqarrow.NewSchemaManifest(prmd.Schema, prmd.KeyValueMetadata(), &pqprops) - if err != nil { - return nil, err - } fr, err := pqarrow.NewFileReader(pr, pqprops, memory.NewGoAllocator()) if err != nil { return nil, err @@ -83,7 +78,7 @@ func NewReader(ctx context.Context, sctx *super.Context, r io.Reader, p sbuf.Pus // Trim trailing "max" or "min". paths[i] = p[:len(p)-1] } - colIndexes := columnIndexes(schemaManifest, paths) + colIndexes := columnIndexes(fr.Manifest, paths) // Remove duplicates created above by trimming "max" and "min". metadataColIndexes = slices.Compact(colIndexes) for range concurrentReaders { @@ -103,8 +98,8 @@ func NewReader(ctx context.Context, sctx *super.Context, r io.Reader, p sbuf.Pus ctx: ctx, sctx: sctx, fr: fr, - colIndexes: columnIndexes(schemaManifest, fields), - colIndexToField: schemaManifest.ColIndexToField, + colIndexes: columnIndexes(fr.Manifest, fields), + colIndexToField: fr.Manifest.ColIndexToField, metadataColIndexes: metadataColIndexes, metadataFilters: metadataFilters, nextRowGroup: &atomic.Int64{},