"Attachments" as targetDef not found

[Andreas-Meindl-msggroup]

Deleting files is not possible as in sdm.js file in method getAttachmentCompositions there is if statement "if (targetDef && targetDef.includes && targetDef.includes.includes('sap.attachments.Attachments'))".
In our case targetDef is not "sap.attachments.Attachments" but only "Attachments".
Deleting a file on UI results in a deleted file on UI attachment table but not in the DMS.

So we extended the if statement by targetDef.includes.includes('Attachments'))) and would like to contribute to this issue by a pull request.

Versions:
@cap-js/db-service: 2.9.0
@cap-js/hana: 2.7.0
@sap/cds: 9.8.3
@sap/cds-compiler: 6.7.3
@sap/cds-dk: 9.7.2
@sap/cds-dk (global): 9.1.0
@cap-js/dm: 1.9.0
Node.js: v22.22.0

[yashmeet29]

Hi @Andreas-Meindl-msggroup,

Thank you for raising this issue and for your willingness to contribute a fix.
Please go ahead and raise a PR. We'll take a look, run the tests on our end, and share any feedback if something needs tweaking. If everything checks out, we'll get it merged.

Regards,
Yashmeet

[Andreas-Meindl-msggroup]

Hi @yashmeet29 ,
We have created Pull Request #249

Regards,
Andreas

[yashmeet29]

Hi @Andreas-Meindl-msggroup,

Thanks for the Pull request, our team will review it. We also need to run tests at our end and might need some discussions around these internally.

Regards,
Yashmeet

[yashmeet29]

Hi @Andreas-Meindl-msggroup,
Can you share how you have imported Attachments aspect in your cds file? Is it like using { Attachments } from '@cap-js/sdm'; or using { sap.attachments.Attachments } from '@cap-js/sdm';

Regards,
Yashmeet

[Andreas-Meindl-msggroup]

Hi @yashmeet29 ,

we have imported it this way:
using { Attachments } from '@cap-js/sdm';

Thats the way, it is mentioned in the docs here: https://github.com/cap-js/sdm#use-cap-jssdm-plugin.

Regards,
Andreas

[yashmeet29]

Hi @Andreas-Meindl-msggroup,
Thanks for this info.

Can you please import it as below, this should fix your issue for now.
using { sap.attachments.Attachments } from '@cap-js/sdm';

Since both sap.attachments.Attachments & Attachments are supported, we will merge your PR and update our ReadMe docs for the same.

Regards,
Yashmeet

[Andreas-Meindl-msggroup]

Hi @yashmeet29 ,

we don`t need a temporary fix, as the fork is running until the PR is merged.

So we will wait until the new release is out.

Regards,
Andreas

[yashmeet29]

Hi @Andreas-Meindl-msggroup,

We have released a new version(1.10.0) of SDM plugin today with this change. Hence closing this issue.

Regards,
Yashmeet