Skip to content

Commit 66c65cc

Browse files
authored
fix(maestro): correct give-button label and sheet dismissal (#1181)
Two pre-existing flow failures on code/cash, unrelated to the beta-flag work: - The give nav button renders "Cash" (GiveButtonLabel.Cash / action_cash), not "Give", so pull_out_bill's `tapOn: Give` never matched. Tap "Cash". - close_open_sheet swiped down once and asserted the scanner, but a destination opened inside a sheet (wallet -> token info) is pushed onto that sheet's own nav stack, so one dismiss only pops a layer. Press Back until the scanner (the root behind the single sheet) is revealed — bounded and guarded so it can't hang CI or back out of the app. This fixes open_token_info_deeplink, which also drops its unasserted (silently no-op) deeplink reopen. Note: claim_cashlink and show_bill_and_put_back_in_wallet now tap Cash correctly but still require an account with a giveable balance (the give flow otherwise shows a deposit/discover prompt instead of the amount keypad) — a provisioning dependency like send_to_contact.
1 parent 3d644ad commit 66c65cc

3 files changed

Lines changed: 39 additions & 15 deletions

File tree

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,23 @@
11
appId: com.flipcash.app.android
22
---
3-
- swipe:
4-
direction: DOWN
5-
- extendedWaitUntil:
6-
visible:
7-
id: scanner_screen
3+
# Return to the scanner, which is always the root behind the single open sheet. Opening a
4+
# destination inside a sheet (e.g. wallet -> token info) pushes it onto that sheet's own nav
5+
# stack, so one dismiss only pops a layer. Press Back until the scanner is revealed: each
6+
# Back pops the sheet's nav stack and the final one dismisses the sheet itself.
7+
#
8+
# Bounded (times) rather than an open while-loop so a stuck sheet can't hang CI, and each
9+
# Back is guarded on the scanner not already showing — so it's a safe no-op on a clean home
10+
# screen and never backs out of the app once the scanner is reached.
11+
- repeat:
12+
times: 5
13+
commands:
14+
- runFlow:
15+
when:
16+
notVisible:
17+
id: scanner_screen
18+
commands:
19+
- pressKey: Back
20+
- waitForAnimationToEnd:
21+
timeout: 1500
22+
- assertVisible:
23+
id: scanner_screen

maestro/open_token_info_deeplink.yaml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
11
appId: com.flipcash.app.android
2+
name: "Token Info deeplink → opens & dismisses to scanner"
3+
tags:
4+
- tokens
25
---
6+
# A token deeplink opens the token-info screen (pushed into a sheet's nav stack over the
7+
# scanner) and can be dismissed cleanly back to the scanner. Re-firing the same deeplink is
8+
# a no-op (the app dedupes it), so this verifies the open + dismiss, which is the meaningful
9+
# path.
310
- runFlow: subflows/login_with_deeplink.yaml
4-
- runFlow:
5-
file: helpers/launch_deeplink.yaml
6-
env:
11+
12+
- runFlow:
13+
file: helpers/launch_deeplink.yaml
14+
env:
715
deeplink: https://app.flipcash.com/token/5APqK9YUZupKt7rRUrpYy6WV3RPuxA71ZtKJffDUMdPP
816
- extendedWaitUntil:
9-
visible:
17+
visible:
1018
id: token_info_screen
19+
timeout: 8000
20+
21+
# Dismiss the sheet back to the scanner (unwinds the sheet's nav stack, then dismisses it).
1122
- runFlow: helpers/close_open_sheet.yaml
12-
- pressKey: home
13-
- runFlow:
14-
file: helpers/launch_deeplink.yaml
15-
env:
16-
deeplink: https://app.flipcash.com/token/5APqK9YUZupKt7rRUrpYy6WV3RPuxA71ZtKJffDUMdPP

maestro/subflows/pull_out_bill.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
appId: com.flipcash.app.android
22
---
33
- runFlow: ../helpers/close_open_sheet.yaml
4-
- tapOn: Give
4+
# The give/cash nav button's label is config-driven (GiveButtonLabel: "Give" or "Cash");
5+
# it currently renders "Cash" (action_cash).
6+
- tapOn: Cash
57
- extendedWaitUntil:
68
visible: Float
79
- extendedWaitUntil:

0 commit comments

Comments
 (0)