From 7e29fb43529636caf5412cb0023c2247cae44e4c Mon Sep 17 00:00:00 2001
From: Stelios <stelios@spapa.us>
Date: Fri, 24 Jul 2026 10:42:18 -0400
Subject: [PATCH] fix(jupyterlab): pass base_url inline instead of via
 BASE_URL_FLAG

---
 registry/coder/modules/jupyterlab/README.md | 4 ++--
 registry/coder/modules/jupyterlab/run.sh    | 6 +-----
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/registry/coder/modules/jupyterlab/README.md b/registry/coder/modules/jupyterlab/README.md
index 0e2b7dcf8..e1fa98724 100644
--- a/registry/coder/modules/jupyterlab/README.md
+++ b/registry/coder/modules/jupyterlab/README.md
@@ -16,7 +16,7 @@ A module that adds JupyterLab in your Coder template.
 module "jupyterlab" {
   count    = data.coder_workspace.me.start_count
   source   = "registry.coder.com/coder/jupyterlab/coder"
-  version  = "1.2.2"
+  version  = "1.2.3"
   agent_id = coder_agent.main.id
 }
 ```
@@ -29,7 +29,7 @@ JupyterLab is automatically configured to work with Coder's iframe embedding. Fo
 module "jupyterlab" {
   count    = data.coder_workspace.me.start_count
   source   = "registry.coder.com/coder/jupyterlab/coder"
-  version  = "1.2.2"
+  version  = "1.2.3"
   agent_id = coder_agent.main.id
   config = {
     ServerApp = {
diff --git a/registry/coder/modules/jupyterlab/run.sh b/registry/coder/modules/jupyterlab/run.sh
index 5edf35ef6..eefd74b2e 100644
--- a/registry/coder/modules/jupyterlab/run.sh
+++ b/registry/coder/modules/jupyterlab/run.sh
@@ -19,10 +19,6 @@ check_available_installer() {
   exit 1
 }
 
-if [ -n "${BASE_URL}" ]; then
-  BASE_URL_FLAG="--ServerApp.base_url=${BASE_URL}"
-fi
-
 BOLD='\033[0;1m'
 
 # check if jupyterlab is installed
@@ -50,7 +46,7 @@ fi
 printf "👷 Starting jupyterlab in background..."
 printf "check logs at ${LOG_PATH}"
 $JUPYTER --no-browser \
-  "$BASE_URL_FLAG" \
+  --ServerApp.base_url=${BASE_URL} \
   --ServerApp.ip='*' \
   --ServerApp.port="${PORT}" \
   --ServerApp.token='' \