Skip to content

Consistent use of XML tags #193

Description

@fhagemann

The unit tests for MAssembly revealed some inconsistencies in how we assign XML tags to nuclearizer modules:
https://github.com/zoglauer/nuclearizer/blob/16400db68d2d3982864b5c606854047ad415408a/unittests/UTNAssembly.cxx#L259-L265

  vector<MString> XmlTags = { "XmlTagLoaderSimulations", "XmlTagMeasurementLoaderROA", "XmlTagMeasurementLoaderHDF",
                              "XmlTagMeasurementLoaderFITS", "XmlTagMeasurementLoaderL0", "XmlTagDEESMEX",
                              "XmlTagEventFilter", "EnergyCalibration", "XmlTagStripPairingMultiRoundChiSquare",
                              "XmlTagStripPairingChiSquare", "DepthCalibration", "XmlTagEventSaver",
                              "XmlTagSaverMeasurementsL0", "XmlTagSaverMeasurementsFITS", "XmlTagTransmitterRealta",
                              "XmlTagResponseGenerator", "XmlTagRevan", "XmlTagTACcut", "XmlTagDiagnostics",
                              "XmlTagDiagnosticsEnergyPerStrip" };

While most of the XML tags start with XmlTag, there is some modules where the naming is a bit awkward:

  • EnergyCalibration (instead of XmlTagEnergyCalibration)
  • DepthCalibration (instead of XmlTagDepthCalibration)

In that sense:
the TAC calibration and cut module right now is called MModuleTACcut, even though it's essentially doing the same thing as EnergyCalibration (calibrating ADC values, and then applying cuts/thresholds).
If we are to rename XML tags, which might be a breaking change for people using nuclearizer config files, we should also think about renaming the module/XML tag to MModuleTACCalibration and XmlTagTACCalibration instead.
(and maybe split the code doing TAC calibration and TAC cuts rather than having everything in the big AnalyzeEvent function).

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions