Empty remediation commit - ok or bad?

[hexagonrecursion]

1. If remediation commits are allowed, the app will warn:

   Please note: You should avoid adding empty commits (i.e., git commit -s --allow-empty), because these will be discarded if someone rebases the branch / repo.

2. On the other hand here the OP suggested adding a UI button that adds empty remediation commits and no one said "empty commit = bad". To me this suggests that the recommendation above does not reflect commonly accepted wisdom.

I think the concern about rebase discarding remediation commits might be moot because remediation commits contain the commit id of the specific commit they are retroactively adding a sign-off to. If the branch is rebased, the remediation commits (even if preserved) will now contain incorrect commit id.

What am I missing?

@brianwarner @gr2m

[GHkrishna]

If the branch is rebased, the remediation commits (even if preserved) will now contain incorrect commit id.
Possibly this could be the reason they are removed during rebasing.

Also, considering the common approach, where, the base branch, usually environment specific branches and main branch is not usually rebased quite often and the ideally only the feature branches must be rebased, which should be comparatively easy, I think the default message makes sense.

Your thoughts @hexagonrecursion ?

Also, on a side note, mind having a look at this discussion here (cncf/dco2#89), since you're aware of remediation commits, might add your suggestions.