From 6e0a9a0a51eb03ed2f4f439f560c84cbf229c336 Mon Sep 17 00:00:00 2001 From: devshinthant Date: Tue, 23 Jun 2026 16:22:54 +0700 Subject: [PATCH 1/4] chore: update preview workflow --- .github/workflows/node-api-ci.yaml | 4 -- .github/workflows/node-api-preview.yaml | 58 +++++++++++++++++++++++++ 2 files changed, 58 insertions(+), 4 deletions(-) diff --git a/.github/workflows/node-api-ci.yaml b/.github/workflows/node-api-ci.yaml index f13ec05..5acd0ec 100644 --- a/.github/workflows/node-api-ci.yaml +++ b/.github/workflows/node-api-ci.yaml @@ -7,10 +7,6 @@ on: paths: - services/node-api/** - .github/workflows/node-api-ci.yaml - pull_request: - paths: - - services/node-api/** - - .github/workflows/node-api-ci.yaml permissions: contents: read diff --git a/.github/workflows/node-api-preview.yaml b/.github/workflows/node-api-preview.yaml index a67e088..da23432 100644 --- a/.github/workflows/node-api-preview.yaml +++ b/.github/workflows/node-api-preview.yaml @@ -13,6 +13,7 @@ on: permissions: contents: read packages: write + pull-requests: read env: IMAGE_NAME: ghcr.io/${{ github.repository }}/node-api @@ -67,3 +68,60 @@ jobs: push: true platforms: linux/amd64,linux/arm64 tags: ${{ steps.image.outputs.image }} + + - name: Checkout main for GitOps update + uses: actions/checkout@v4 + with: + ref: main + + - name: Generate preview application + run: | + PR_NUMBER="${{ github.event.pull_request.number }}" + PREVIEW_NAME="node-api-pr-${PR_NUMBER}" + PREVIEW_NAMESPACE="preview-node-api-pr-${PR_NUMBER}" + IMAGE_TAG="${{ steps.image.outputs.tag }}" + + mkdir -p previews/node-api + + cat > "previews/node-api/pr-${PR_NUMBER}.yaml" < Date: Tue, 23 Jun 2026 16:28:41 +0700 Subject: [PATCH 2/4] fix: node-api-preview workflow --- .github/workflows/node-api-preview.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node-api-preview.yaml b/.github/workflows/node-api-preview.yaml index da23432..788903c 100644 --- a/.github/workflows/node-api-preview.yaml +++ b/.github/workflows/node-api-preview.yaml @@ -11,7 +11,7 @@ on: - .github/workflows/node-api-preview.yaml permissions: - contents: read + contents: write packages: write pull-requests: read From a42b355318d723e5e8dba1a16965e3be06281000 Mon Sep 17 00:00:00 2001 From: devshinthant Date: Tue, 23 Jun 2026 16:41:12 +0700 Subject: [PATCH 3/4] fix: app file content creation in node-api preview workflow --- .github/workflows/node-api-preview.yaml | 54 ++++++++++++------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/node-api-preview.yaml b/.github/workflows/node-api-preview.yaml index 788903c..95be0b8 100644 --- a/.github/workflows/node-api-preview.yaml +++ b/.github/workflows/node-api-preview.yaml @@ -83,33 +83,33 @@ jobs: mkdir -p previews/node-api - cat > "previews/node-api/pr-${PR_NUMBER}.yaml" < "previews/node-api/pr-${PR_NUMBER}.yaml" - name: Commit preview application run: | From d2256e90f4b00a05d9a8569b0b28b393e5c62528 Mon Sep 17 00:00:00 2001 From: devshinthant Date: Tue, 23 Jun 2026 17:13:31 +0700 Subject: [PATCH 4/4] fix: remove imagePullSecrets as node-api package from ghcr turned into public --- .github/workflows/node-api-ci.yaml | 1 - charts/node-api/templates/deployment.yaml | 3 --- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/node-api-ci.yaml b/.github/workflows/node-api-ci.yaml index 5acd0ec..1398894 100644 --- a/.github/workflows/node-api-ci.yaml +++ b/.github/workflows/node-api-ci.yaml @@ -59,7 +59,6 @@ jobs: context: services/node-api push: true platforms: linux/amd64,linux/arm64 - tags: | ${{ env.IMAGE_NAME }}:main ${{ env.IMAGE_NAME }}:${{ github.sha }} diff --git a/charts/node-api/templates/deployment.yaml b/charts/node-api/templates/deployment.yaml index 86270f5..3762944 100644 --- a/charts/node-api/templates/deployment.yaml +++ b/charts/node-api/templates/deployment.yaml @@ -33,6 +33,3 @@ spec: port: {{ .Values.service.targetPort }} resources: {{- toYaml .Values.resources | nindent 12 }} - imagePullSecrets: - {{- toYaml .Values.imagePullSecrets | nindent 8 }} -