-
Notifications
You must be signed in to change notification settings - Fork 1
CodeRabbit auto-review never fires: inherited label gate deadlocks against auto_apply_labels #1424
Copy link
Copy link
Closed
Labels
agentic-workflowsbugSomething isn't workingSomething isn't workingci-cdci/cddocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestfrontendgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codehigh-priorityUrgent - blocks revenue or core functionalityUrgent - blocks revenue or core functionalityinfrastructurepipelinepriority:highquestionFurther information is requestedFurther information is requestedtriaged
Description
Activity
Metadata
Metadata
Assignees
Labels
agentic-workflowsbugSomething isn't workingSomething isn't workingci-cdci/cddocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestfrontendgithub_actionsPull requests that update GitHub Actions codePull requests that update GitHub Actions codehigh-priorityUrgent - blocks revenue or core functionalityUrgent - blocks revenue or core functionalityinfrastructurepipelinepriority:highquestionFurther information is requestedFurther information is requestedtriaged
Summary
CodeRabbit auto-review is skipped on every pull request in this repository. The
CodeRabbitcommit status reads:The cause is a required-labels gate inherited from the CodeRabbit dashboard / org UI. It is not present in
.coderabbit.yaml, so it is invisible in the repo and has never been reviewed in a PR.The deadlock
The inherited gate requires at least one of ~26 labels before a review will start:
Four of these —
architecture-gap,ci-cd,pipeline-critical,placeholder-code— are labels CodeRabbit itself applies, as part of a review, viareviews.auto_apply_labels: trueandreviews.labeling_instructionsin.coderabbit.yaml.A pull request opens unlabelled. The gate therefore skips it, and because the review never runs, nothing applies a label that would un-skip it. Labelling after the fact does not retro-trigger the review.
Evidence
Both currently-open non-draft PRs, on their current heads:
CodeRabbitstatus8628b5eReview skipped: excluded by label configuration3f72b75Review skipped: excluded by label configuration#1410 carries
documentationandci-cd, both of which are in the required list — and it is still skipped, because the labels were added after open. This is recorded on the PR itself:Every CodeRabbit review this repo has received was requested by hand with
@coderabbitai full review.Why it matters
Any automated PR-remediation loop that expects CodeRabbit to review on open silently gets nothing. The failure is quiet — the commit status is
success, not a failure, so a green CodeRabbit status currently means "did not review" just as often as it means "reviewed and found nothing".Secondary finding
.coderabbit.yaml's header claims to be the single source of truth for settings that previously lived only in the dashboard. This gate was not in it. Withinheritance: true, any setting the file leaves unset can be overridden from the dashboard without review — so "unset" is not a safe way to express "I want the default".Acceptance criteria
reviews.auto_review.labelsis set explicitly in.coderabbit.yamlso the inherited gate no longer appliesdrafts: falseunchanged)