Skip to content

Orphaned truth-gate fixture left behind by #1431 #1474

Description

@groupthinking

Problem

ci: retire the agent-completion truth gate (#1431) (8cd4a10ca) deleted both consumers of tests/fixtures/agent_completion/pr_813.json:

  • scripts/ci/agent_completion_gate.py — deleted
  • tests/unit/test_agent_completion_gate.py — deleted

The fixture itself was not deleted, so tests/fixtures/agent_completion/ remains on main with no reader.

Evidence

$ git ls-tree -r --name-only origin/main | grep -E 'agent_completion_gate|agent-completion-enforcement'
(no output — both deleted)

$ grep -rn "agent_completion" --include=*.py --include=*.yml --include=*.yaml \
    --include=*.md --include=*.json --include=*.sh . | grep -v '^./tests/fixtures/agent_completion/'
./docs/runbook/pr-remediation-report-2026-08-04.md:11:> `agent-completion-enforcement.yml`, `agent_completion_gate.py`, and

The single remaining hit is a historical runbook narrating the retirement. It is prose about the deletion, not a load of the fixture, and should stay as written.

Why it matters

The fixture encodes the retired gate's payload schema (policy.applicable, agent_login, run_id, head_sha). Left in the tree it reads as a live contract for a mechanism that no longer exists — the same class of misleading-artifact problem #1431 and #1434 were closing.

Acceptance criteria

  • tests/fixtures/agent_completion/ is removed from the tree.
  • No test collection error or new failure results — verified by running the suites that reference tests/fixtures/.
  • The historical runbook reference in docs/runbook/pr-remediation-report-2026-08-04.md is left unchanged.

Scope

Deletion only. This issue does not reopen the truth-gate decision, which #1431 settled.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions