Skip to content

fix(logging): residual JSON fallback can still drop records after #1491 #1525

Description

@groupthinking

Summary

#1491 closed #1452 for circular containers and exploding __str__, but the recovery path can still raise. Three residual holes:

  1. Exception whose own __str__ raises when formatting the fallback
  2. Values forging __class__ = str that pass isinstance then fail in dump
  3. Large ints past sys.get_int_max_str_digits() and non-finite floats (allow_nan=False)

Acceptance

Context

Implemented by #1515.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions