Skip to content

fix(a11y): complete dashboard focus contrast and regression coverage #919

Description

@groupthinking

Parent program

Progresses #898.

Canonical implementation

Canonical branch/PR: claude/determined-maxwell-o4am5t / #1049. PR #1045 and other overlapping accessibility branches remain duplicate evidence only.

Objective

Complete the dashboard keyboard-focus work by:

  • raising the Dispatch focus ring to sufficient contrast;
  • raising the Refresh focus ring to sufficient contrast;
  • retaining regression coverage for the focus-visible classes and the Go button's aria-busy behavior.

Declared file scope

  • apps/web/src/components/dashboard/panels.tsx
  • apps/web/src/lib/__tests__/dashboard-search-accessibility.test.ts

Acceptance evidence

  • Dispatch uses ring-indigo-400/70; Refresh uses ring-white/40.
  • Regression coverage scopes each focus-ring assertion to its specific button and tracks aria-busy from searchLoading.
  • Exact head cc833f5284d1d96cadf99edda842ba4f1c5c79f1 is three commits ahead and zero behind main@995fa2682809483b483be7fddee43b834ed0d4f7, changing only the two declared files.
  • CI, Coverage, CodeQL, Security Scan, Secret Scan, and Dependency Review pass; E2E is repository-skipped.
  • Both substantive review threads are resolved. CodeRabbit approved the exact head and confirmed the button-scoped regression fix.
  • Vercel preview dpl_DLiC1qKkDkKTs8L9aQ2hXkC95xYF is READY on exact head cc833f5284d1d96cadf99edda842ba4f1c5c79f1.
  • PR fix(a11y): complete dashboard focus contrast and regression coverage #1049 remains draft; no merge is authorized.

Exact-head workflow evidence

  • CI: run 30456585527 — success
  • Coverage: run 30456585535 — success
  • CodeQL Analysis: run 30456585922 — success
  • Security Scan: run 30456585721 — success
  • Secret Scan: run 30456585227 — success
  • Dependency Review: runs 30456585433 and 30456732906 — success
  • E2E Tests: run 30456585614 — repository-skipped
  • Review threads: 2 resolved, 0 unresolved
  • Preview: https://vercel.com/garv1/v0-uvai/DLiC1qKkDkKTs8L9aQ2hXkC95xYF — READY on exact head

Execution receipt

Result

Focused corrective unit completed. Close only #919. Keep #1049 draft for portfolio-level merge governance.

No merge, production deployment, branch deletion, credential/ruleset change, or competing implementation is authorized.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions