Skip to content

test_runner_retry (21 tests) + test_deploy (1) are non-hermetic: live gh-client via repairs flow #456

Description

@hadamrd

Found during the #454/#455 gate work (2026-06-11): the full suite shows 22 failures in any shell WITHOUT GITHUB_TOKEN, and the same tests PASS (slowly — ~50s each, making real GitHub API calls) when the token is present. Bisect: reproduces on e457519 (pre-#454) — pre-existing, masked because loop-launch shells always export the token.

Escape path: tests/test_runner_retry.py → tick.py → repairs.py:86 → gh_issues.py:368 → gh_client._require_token (RuntimeError without token; live API with).

Fix: stub the repairs flow's gh surface at the test boundary (same pattern as test_orphan_pr_adoption's _patch_gh, which gained a fetch_issue stub in #455). Tests must never construct a live gh client.

Severity: CI/dev-env dependent suite + accidental live API traffic from unit tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions