Code quality findings from Cppcheck

[github-actions]

CoreVideo Code Quality Findings

Cppcheck reported non-sensitive maintainability findings. Security-sensitive scanner output is intentionally not mirrored into public issues.

Summary

• information: 5
• portability: 4
• style: 204

Top Findings

• style useStlAlgorithm src/cv-ffmpeg-loader.cpp:111 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/iso-ffmpeg-pipe.cpp:259 - Consider using std::transform algorithm instead of a raw loop.
• style knownConditionTrueFalse src/talkback-plan.h:108 - Condition 'all_talent_channels==need' is always false
• style useStlAlgorithm src/talkback-nomination.h:315 - Consider using std::find_if algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-plan.h:87 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-plan.h:216 - Consider using std::find_if algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-plan.h:265 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-plan.h:293 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-plan.h:312 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-dock-state.h:159 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-dock-state.h:280 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-dock-state.h:486 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-dock-state.h:488 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/talkback-cell-grid.cpp:184 - Consider using std::find_if algorithm instead of a raw loop.
• style shadowFunction src/shm-generation.h:103 - Local variable 'issued' shadows outer function
• style constVariablePointer src/talkback-ring.h:106 - Variable 'hdr' can be declared as pointer to const
• style useStlAlgorithm src/zoom-engine-client.cpp:1769 - Consider using std::any_of algorithm instead of a raw loop.
• style constVariableReference src/zoom-iso-recorder.cpp:692 - Variable 'session' can be declared as reference to const
• style useStlAlgorithm src/zoom-iso-recorder.cpp:293 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-iso-recorder.cpp:296 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-iso-recorder.cpp:527 - Consider using std::count_if algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-iso-recorder.cpp:576 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/audio-loudness.h:409 - Consider using std::accumulate algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-participant-audio-source.cpp:522 - Consider using std::find_if algorithm instead of a raw loop.
• style constVariablePointer src/zoom-supersource.cpp:2452 - Variable 'ref' can be declared as pointer to const
• style useStlAlgorithm src/zoom-tile-animator.h:65 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:310 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:331 - Consider using std::all_of or std::none_of algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:389 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:439 - Consider using std::find_if algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:458 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tile-animator.h:461 - Consider using std::any_of algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tiles-audio-plan.h:84 - Consider using std::find_if algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-tiles-audio-plan.h:90 - Consider using std::find_if algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-supersource.cpp:1434 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-supersource.cpp:1441 - Consider using std::transform algorithm instead of a raw loop.
• style useStlAlgorithm src/zoom-supersource.cpp:1641 - Consider using std::any_of algorithm instead of a raw loop.
• style constVariablePointer src/zoom-tiles-audio.cpp:328 - Variable 'item' can be declared as pointer to const
• information missingInclude engine/src/engine-talkback.h:27 - Include file: "zoom_sdk.h" not found.
• information missingInclude engine/src/engine-talkback.h:28 - Include file: "meeting_service_interface.h" not found.

Plus 173 additional findings in the workflow artifact.

Workflow run: https://github.com/iamfatness/CoreVideo/actions/runs/33995376651