Add helper function in dynamic schema parsing

[mjudeikis]

Currently, schemas are parsed in not a very type-safe way:

Example:

scope := item.UnstructuredContent()["spec"].(map[string]interface{})["scope"]

We should add a helper function to do this better

[RyanCarlisle]

Hi @mjudeikis , is this done already? If not, could you tell me more about the scope of the work, as in which parsing I should be more focused at or is it for all types of parsing that are there in the above-mentioned way.

[mjudeikis]

If you look into code, you will find 1 place now where we do this unstructure casting. This is not type safe as it can panic. We just need to write some helper function to help with this to make sure we dont panic where we dont need to. Something like:

spec, ok := item.UnstructuredContent()["spec"]
if !ok {
   return error
}
scope, ok := spec.(map[string]interface{})["scope"]
if !ok {
   return error
}

but do above ^ with some smarter recursion or maybe see if there exists libararies to do so. I know crossplane has one for sure.

[RyanCarlisle]

@mjudeikis kindly review the PR (#294) and let me know if this approach works. Also, please let me kow if there are any changes required to be made here.

[mjudeikis]

@RyanCarlisle I think this might be fixed by #295 as most of the code changed in there. :/

my mistake, still needed

[mjudeikis]

This will be sligtly changed in #304 so I dont think we gonna need it. Sorry :/ just took bit too long

[RyanCarlisle]

Okay, no problem. Closing my PR now