From 8c2cbd415e78d1591e9a8705e7983be9a637cf97 Mon Sep 17 00:00:00 2001 From: kkdev92 Date: Sun, 30 Aug 2026 01:37:16 +0900 Subject: [PATCH] chore(deps): vscode-ext-kit 4.1.0, and editor.tabSize declared as read-only MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `@kkdev92/vscode-ext-kit` `^4.0.0` → `^4.1.0`. `EditorSettings` declares `contributed: false`: the `editor.tabSize` group is a section this extension reads and does not own, and 4.1.0 lets the declaration say so, so the framework's manifest check stops asking package.json for it. The bundle grows by 6,415 bytes, all of it framework runtime 4.1.0 added and this extension links; `describePlan` and `diffManifest`, reached only through a test or the command line, are absent from it. The 4.0.1 tree-view fix rides along. Co-Authored-By: Claude Fable 5 --- CHANGELOG.md | 20 ++++++++++++++++++++ package-lock.json | 11 +++++++---- package.json | 2 +- src/core/config.ts | 5 +++++ 4 files changed, 33 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 85c6576..dc1eb6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,26 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- `@kkdev92/vscode-ext-kit` `^4.0.0` → `^4.1.0`, and `EditorSettings` declares + `contributed: false`. The `editor.tabSize` group has always been a section + this extension reads and does not own; 4.1.0 lets the declaration say so, and + the framework's manifest check — now also a command, `vscode-ext-kit manifest` + — stops asking `package.json` for an `editor.tabSize` entry. Run against this + extension's bundle, it reports `manifest ok: 47 command(s), 10 setting(s), + 3 view(s) agree`; before the flag it reported that one setting as missing. + + **The bundle grows by 6,415 bytes (348,529 → 354,944), and the growth is + accounted for.** Built against both kit versions and compared: `KIT_VERSION` + now reads `4.1.0`, and the rest is framework runtime that 4.1.0 added and + this extension links — a preflight failure reported as data rather than + sentences, a shutdown timeout that names the hosted service, operations and + scopes still holding it, `inspect()` on both scope kinds, and + `defineExtension` refusing a second activation after `deactivate`. Nothing + reached through a test or the command line enters the bundle: `describePlan` + and `diffManifest` are absent from it, as they should be. The 4.0.1 fix rides + along as well — the tree-view adapter no longer disposes a module-declared + provider twice on deactivation, which this extension's view was subject to. + - `@kkdev92/vscode-ext-kit` `^3.0.0` → `^4.0.0`. The framework raised its own `engines.vscode` to `^1.134.0`, which this extension already declares, so the two now agree instead of the extension quietly requiring more than the library diff --git a/package-lock.json b/package-lock.json index dd1bfea..011cce2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.4.0", "license": "MIT", "dependencies": { - "@kkdev92/vscode-ext-kit": "^4.0.0" + "@kkdev92/vscode-ext-kit": "^4.1.0" }, "devDependencies": { "@eslint/js": "^10.0.0", @@ -936,10 +936,13 @@ } }, "node_modules/@kkdev92/vscode-ext-kit": { - "version": "4.0.0", - "resolved": "https://registry.npmjs.org/@kkdev92/vscode-ext-kit/-/vscode-ext-kit-4.0.0.tgz", - "integrity": "sha512-8hKKvRCciiy06wKneqqw/ojE3MKh/gVVyAsWuxeCZeSceR8rKFB6hEt/11eRUVeh3Lf4o/2xsPIDBxasGsdcog==", + "version": "4.1.0", + "resolved": "https://registry.npmjs.org/@kkdev92/vscode-ext-kit/-/vscode-ext-kit-4.1.0.tgz", + "integrity": "sha512-TiwfqvLhgQW5oaFCkjPY4zyK+S6QaJ+7AxRA633QClM8j8Yg7fR26jk9K0gWnrw7oi9cokeSNpJo2IjeGbTDsQ==", "license": "MIT", + "bin": { + "vscode-ext-kit": "bin/vscode-ext-kit.mjs" + }, "engines": { "node": ">=22.12.0", "vscode": "^1.134.0" diff --git a/package.json b/package.json index 47447d6..f9c31ad 100644 --- a/package.json +++ b/package.json @@ -565,7 +565,7 @@ "clean": "rimraf dist coverage .vsix-verify-temp quick-utils.vsix" }, "dependencies": { - "@kkdev92/vscode-ext-kit": "^4.0.0" + "@kkdev92/vscode-ext-kit": "^4.1.0" }, "devDependencies": { "@eslint/js": "^10.0.0", diff --git a/src/core/config.ts b/src/core/config.ts index bfae161..363a721 100644 --- a/src/core/config.ts +++ b/src/core/config.ts @@ -62,12 +62,17 @@ export type Config = SettingsAccessor; * declaration: a settings group is scoped to one section, and re-declaring a * VS Code-owned setting under `quickUtils.*` would mean maintaining a second * source of truth for something the editor already tracks. + * + * `contributed: false` says the same thing to the tooling: this extension reads + * the section and does not contribute it, so the manifest check does not ask + * `package.json` for an `editor.tabSize` entry. */ export const EditorSettings = defineSettings({ section: 'editor', values: { tabSize: setting.integer({ default: 4, minimum: 1, maximum: 16 }), }, + contributed: false, }); /** What a feature is handed to read `editor.*`. */