From ddce6d7388d74939bf843c8c4318fcff38a8d80f Mon Sep 17 00:00:00 2001 From: rdeiser Date: Fri, 3 Apr 2026 09:42:29 -0500 Subject: [PATCH 1/3] fix(traffic-result-limit.components.ts): updates the offsetvalue to be greaterthan or equal to zero since the component is tied to the no records found module --- .../traffic-result-limit.component.ts | 89 ++++++++++--------- 1 file changed, 45 insertions(+), 44 deletions(-) diff --git a/src/app/traffic-result-limit/traffic-result-limit.component.ts b/src/app/traffic-result-limit/traffic-result-limit.component.ts index 631fc1ae..40eda277 100644 --- a/src/app/traffic-result-limit/traffic-result-limit.component.ts +++ b/src/app/traffic-result-limit/traffic-result-limit.component.ts @@ -1,44 +1,45 @@ - import { Component, OnInit } from '@angular/core'; - import { Location, NgIf } from '@angular/common'; - - @Component({ - selector: 'custom-traffic-result-limit', - standalone: true, - imports: [NgIf], - templateUrl: './traffic-result-limit.component.html', - styleUrl: './traffic-result-limit.component.scss', - }) - export class TrafficResultLimitComponent implements OnInit { - showComponent: boolean = false; - offsetValue: number | null = null; - - constructor(private location: Location) {} - - ngOnInit(): void { - this.checkOffset(); - } - - checkOffset(): void { - const url = this.location.path(); - const queryString = url.includes('?') ? url.split('?')[1] : ''; - - if (!queryString) { - this.showComponent = false; - return; - } - - const urlParams = new URLSearchParams(queryString); - const offsetParam = urlParams.get('offset'); - - if (offsetParam) { - const offsetValue = parseInt(offsetParam, 10); - if (!isNaN(offsetValue) && offsetValue > 500) { - this.showComponent = true; - } else { - this.showComponent = false; - } - } else { - this.showComponent = false; - } - } - } \ No newline at end of file +import { Component, OnInit } from '@angular/core'; +import { Location, NgIf } from '@angular/common'; + +@Component({ + selector: 'custom-traffic-result-limit', + standalone: true, + imports: [NgIf], + templateUrl: './traffic-result-limit.component.html', + styleUrl: './traffic-result-limit.component.scss', +}) +export class TrafficResultLimitComponent implements OnInit { + showComponent: boolean = false; + offsetValue: number | null = null; + + constructor(private location: Location) {} + + ngOnInit(): void { + this.checkOffset(); + } + + checkOffset(): void { + const url = this.location.path(); + const queryString = url.includes('?') ? url.split('?')[1] : ''; + + if (!queryString) { + this.showComponent = false; + return; + } + + const urlParams = new URLSearchParams(queryString); + const offsetParam = urlParams.get('offset'); + + if (offsetParam) { + const offsetValue = parseInt(offsetParam, 10); + // if the user uses the navigation button, this will display with the offset is `550`. If `500` is mannually added to the `offset` parameter within the browser url box, this will not dispaly if the the below function is set to `offsetValue > 500`. Think about making this change within production before going live. + if (!isNaN(offsetValue) && offsetValue >= 0) { + this.showComponent = true; + } else { + this.showComponent = false; + } + } else { + this.showComponent = false; + } + } +} From cac7ffe23c9e72713112e37da58856e1cd604220 Mon Sep 17 00:00:00 2001 From: rdeiser Date: Mon, 11 May 2026 09:07:03 -0500 Subject: [PATCH 2/3] fix(customComponentMappings-for-pay-fines): payfinescomponent placement within the application was moved to only display within the fines + fees module --- src/app/custom1-module/customComponentMappings.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/custom1-module/customComponentMappings.ts b/src/app/custom1-module/customComponentMappings.ts index f4a78171..3d6928ea 100644 --- a/src/app/custom1-module/customComponentMappings.ts +++ b/src/app/custom1-module/customComponentMappings.ts @@ -7,7 +7,7 @@ import { TrafficResultLimitComponent } from '../traffic-result-limit/traffic-res // Define the map export const selectorComponentMap = new Map([ ['nde-footer-after', Libraryh3lpComponent], - ['nde-account-section-results-before', PayFinesComponent], + ['nde-fines-before', PayFinesComponent], ['nde-full-display-service-container-after', NdeProblemReportCustom], ['nde-top-bar-after', LibraryAlertsPannelComponent], ['nde-search-no-results-before', TrafficResultLimitComponent] From 1a0d33b15829def08c40c37e8305156f98385d3f Mon Sep 17 00:00:00 2001 From: rdeiser Date: Mon, 11 May 2026 09:17:58 -0500 Subject: [PATCH 3/3] build(zip.yml): force node24 to remove github warrning --- .github/workflows/zip.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/zip.yml b/.github/workflows/zip.yml index f8c52e4c..fd07fdaf 100644 --- a/.github/workflows/zip.yml +++ b/.github/workflows/zip.yml @@ -6,6 +6,8 @@ on: jobs: build: runs-on: ubuntu-latest + env: + FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: 'true' steps: - name: Check out repository uses: actions/checkout@v4