Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Condition $expression hint as string  #305

@zajca

Description

@zajca

In examples like https://github.com/lexik/LexikFormFilterBundle/blob/master/Resources/doc/working-with-the-bundle.md#ii-filter-customization user can see return $filterQuery->createCondition($expression, $parameters); where $expressing can be Composite but internally phpdoc hint is string. This will throw error in static analysis like Phpstan.
I suggests that this should be changed to mixed or in documentation should be $expression cast to string
return $filterQuery->createCondition((string)$expression, $parameters);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions