From bae08c7dea5e1c51a0d4cc3352e1ba8eb9c279d1 Mon Sep 17 00:00:00 2001 From: konard Date: Sun, 14 Sep 2025 08:46:15 +0300 Subject: [PATCH 1/3] Initial commit with task details for issue #28 Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: https://github.com/linksplatform/Disposables/issues/28 --- CLAUDE.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 CLAUDE.md diff --git a/CLAUDE.md b/CLAUDE.md new file mode 100644 index 0000000..01857e9 --- /dev/null +++ b/CLAUDE.md @@ -0,0 +1,5 @@ +Issue to solve: https://github.com/linksplatform/Disposables/issues/28 +Your prepared branch: issue-28-e0776703 +Your prepared working directory: /tmp/gh-issue-solver-1757828772164 + +Proceed. \ No newline at end of file From cb9f18ee227b32761d2ee0f44a9d64779892d9e0 Mon Sep 17 00:00:00 2001 From: konard Date: Sun, 14 Sep 2025 08:50:59 +0300 Subject: [PATCH 2/3] Remove conditional compilation for .NET Framework MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removed the #if NET472 conditional compilation directives that were using string.Join() for .NET Framework and simplified to use Path.Combine() for all target frameworks. Also updated the test runner to use net8 instead of net7. This resolves issue #28 by eliminating the special case for .NET Framework since the project now only targets .NET 8. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- csharp/Platform.Disposables.Tests/DisposableTests.cs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/csharp/Platform.Disposables.Tests/DisposableTests.cs b/csharp/Platform.Disposables.Tests/DisposableTests.cs index caa19fb..68dde86 100644 --- a/csharp/Platform.Disposables.Tests/DisposableTests.cs +++ b/csharp/Platform.Disposables.Tests/DisposableTests.cs @@ -42,7 +42,7 @@ private static ProcessStartInfo CreateProcessStartInfo(string logPath, bool wait return new ProcessStartInfo { FileName = "dotnet", - Arguments = $"run -p \"{projectPath}\" -f net7 \"{logPath}\" {waitForCancellation.ToString()}", + Arguments = $"run -p \"{projectPath}\" -f net8 \"{logPath}\" {waitForCancellation.ToString()}", UseShellExecute = false, CreateNoWindow = true }; @@ -67,11 +67,7 @@ private static string GetDisposalObjectTestProjectFilePath() } } pathParts = newPathParts.ToArray(); -#if NET472 - var directory = string.Join(Path.DirectorySeparatorChar.ToString(), pathParts.ToArray()); -#else var directory = Path.Combine(pathParts); -#endif var path = Path.Combine(directory, $"{disposalOrderTestProjectName}.csproj"); if (!Path.IsPathRooted(path)) { From b4c5bd54aa21a2285d7dc9393d14ddd0eef9edae Mon Sep 17 00:00:00 2001 From: konard Date: Sun, 14 Sep 2025 08:51:35 +0300 Subject: [PATCH 3/3] Remove CLAUDE.md - Claude command completed --- CLAUDE.md | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 CLAUDE.md diff --git a/CLAUDE.md b/CLAUDE.md deleted file mode 100644 index 01857e9..0000000 --- a/CLAUDE.md +++ /dev/null @@ -1,5 +0,0 @@ -Issue to solve: https://github.com/linksplatform/Disposables/issues/28 -Your prepared branch: issue-28-e0776703 -Your prepared working directory: /tmp/gh-issue-solver-1757828772164 - -Proceed. \ No newline at end of file