Problem
poetry run ruff check src/ tests/ reports ten errors. None are in the roach-ecology work — every one predates it, and they have been quietly failing the repo-wide lint the whole time:
| Rule |
Where |
What |
| E731 x7 |
analyze.py:35, analyze_lag.py:51, arc.py:62,109,110,139,140 |
lambda assigned to a name instead of def |
| E741 x1 |
arc.py:34 |
Ambiguous variable name l |
| F401 x2 |
cursor.py:27 |
DEFAULT_PROFILE and TREMOR_PROFILE imported but unused |
Wanted
Clear them so a clean ruff check src/ tests/ means something. Until it does, the repo-wide command is useless as a gate — a real new problem is invisible in the existing noise, which is why per-file linting was used throughout the ecology work.
Careful with the two F401s
Those imports are deliberate re-exports — there is a comment directly above them saying so, and callers are meant to be able to write from silphe.cursor import TREMOR_PROFILE. Deleting them, which is what --fix would do, is a breaking change to the public surface. Add them to an __all__ or mark them explicitly instead.
Notes
Cosmetic; blocks nothing. Filed so the noise is a tracked decision rather than something every future session rediscovers and works around.
Problem
poetry run ruff check src/ tests/reports ten errors. None are in the roach-ecology work — every one predates it, and they have been quietly failing the repo-wide lint the whole time:analyze.py:35,analyze_lag.py:51,arc.py:62,109,110,139,140lambdaassigned to a name instead ofdefarc.py:34lcursor.py:27DEFAULT_PROFILEandTREMOR_PROFILEimported but unusedWanted
Clear them so a clean
ruff check src/ tests/means something. Until it does, the repo-wide command is useless as a gate — a real new problem is invisible in the existing noise, which is why per-file linting was used throughout the ecology work.Careful with the two F401s
Those imports are deliberate re-exports — there is a comment directly above them saying so, and callers are meant to be able to write
from silphe.cursor import TREMOR_PROFILE. Deleting them, which is what--fixwould do, is a breaking change to the public surface. Add them to an__all__or mark them explicitly instead.Notes
Cosmetic; blocks nothing. Filed so the noise is a tracked decision rather than something every future session rediscovers and works around.