From 98aab7db1325b21ec4325ee70f9ce6463957015d Mon Sep 17 00:00:00 2001 From: Johannes Rudolph Date: Mon, 7 Sep 2026 20:43:54 +0200 Subject: [PATCH] refactor(meshstack/noop): take the runner's endpoint from test_context The last environment fact this module read from a TF_VAR_. The harness now publishes the endpoint in test_context, so the module reads it there like everything else, and the workflow's export can go. Co-Authored-By: Claude Opus 5 --- modules/meshstack/noop/e2e/runner/main.tf | 2 +- modules/meshstack/noop/e2e/runner/variables.tf | 10 +++------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/modules/meshstack/noop/e2e/runner/main.tf b/modules/meshstack/noop/e2e/runner/main.tf index 7616bfe5..9c4f5259 100644 --- a/modules/meshstack/noop/e2e/runner/main.tf +++ b/modules/meshstack/noop/e2e/runner/main.tf @@ -2,7 +2,7 @@ module "backplane" { source = "../../backplane" meshstack_workspace_identifier = var.test_context.workspace - meshstack_endpoint = var.meshstack_endpoint + meshstack_endpoint = var.test_context.meshstack_endpoint gcp_project_id = var.test_context.fixtures.gcp.project_id gcp_region = var.gcp_region gcp_resource_name_prefix = "noop-runner-${var.test_context.name_suffix}" diff --git a/modules/meshstack/noop/e2e/runner/variables.tf b/modules/meshstack/noop/e2e/runner/variables.tf index 07d71f83..eadaf58e 100644 --- a/modules/meshstack/noop/e2e/runner/variables.tf +++ b/modules/meshstack/noop/e2e/runner/variables.tf @@ -5,6 +5,9 @@ variable "test_context" { project = string name_suffix = string + # Base URL of the meshStack API, written into the runner config for API polling. + meshstack_endpoint = string + # Project the runner's Cloud Run service and Secret Manager secrets live in. fixtures = object({ gcp = object({ @@ -20,10 +23,3 @@ variable "gcp_region" { default = "europe-west1" description = "GCP region for the Cloud Run service and Secret Manager replicas." } - -# Not secret, so this belongs in test_context (see the e2e-test skill) — but the harness does not -# publish it there yet; it reaches CI through the secret pipe. Move it over once it does. -variable "meshstack_endpoint" { - type = string - description = "Base URL of the meshStack API. Written into the runner config for API polling." -}