Skip to content

update and correct zh-hant translation#830

Merged
lhecker merged 2 commits into
microsoft:mainfrom
petercpg:fix-zh-tw-l10n
Apr 29, 2026
Merged

update and correct zh-hant translation#830
lhecker merged 2 commits into
microsoft:mainfrom
petercpg:fix-zh-tw-l10n

Conversation

@petercpg

Copy link
Copy Markdown
Contributor

No description provided.

@petercpg

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@lhecker lhecker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lhecker

lhecker commented Apr 29, 2026

Copy link
Copy Markdown
Member

BTW I know that the UI localization is broken. A PR will be out soon.

@lhecker lhecker enabled auto-merge (squash) April 29, 2026 16:19
Comment thread i18n/edit.toml Outdated
vi = "Tab"
zh_hans = "制表符"
zh_hant = "製表符"
zh_hant = "Tab"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really! in English?

@lhecker lhecker Apr 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL. Woops.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, actually for some terms we just leave it intact for easier understanding. So does for many other special keys.

This is probably first time I've heard it in Chinese :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out VS Code also uses the English word. Perhaps I should've used that instead of Wikipedia... 🤦‍♂️

I'll fix this in my upcoming PR. I hurried with merging this one because I have an upcoming one that will conflict.

@lhecker lhecker Apr 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't see your comment @petercpg until I refreshed. It seems GitHub's lagging again today... 🙈

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see you now, too. No worries!

@lhecker lhecker added the A-localization Area: Localization label Apr 29, 2026
@lhecker lhecker disabled auto-merge April 29, 2026 16:21
@lhecker lhecker enabled auto-merge (squash) April 29, 2026 16:32
@lhecker lhecker merged commit 58408a7 into microsoft:main Apr 29, 2026
3 checks passed
@petercpg

Copy link
Copy Markdown
Contributor Author

@lhecker please do not use 定位字元 for tabs, it's correct though but we unlikely use this way. People just understand Tabs and Spaces for indents enough.

@lhecker

lhecker commented Apr 29, 2026

Copy link
Copy Markdown
Member

I've opened #835 now which rewrites all of the translations. It was the reason I hurried with your PR. I apologize for that. It includes the fix for the incorrect "tab" translation. 🙂

@petercpg petercpg deleted the fix-zh-tw-l10n branch April 29, 2026 16:54
@ChiahongHong

Copy link
Copy Markdown

Hello @petercpg, thank you for helping improve these Traditional Chinese translations!

The translation quality is much better now. I noticed just a couple of small points that I’d like to discuss:

  • Undo should remain translated as 復原, because 還原 means Restore.

    zh-hant = "還原"

  • Find should remain translated as 尋找, because 搜尋 means Search.

    zh-hant = "搜尋:"

We can also use Notepad or Microsoft Terminology Search as references:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-localization Area: Localization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants