From 717f6764d52b595489df8669fa0f64213888c8d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Guillot?= <323546+fguillot@users.noreply.github.com> Date: Mon, 23 Mar 2026 21:02:08 -0700 Subject: [PATCH] fix(client): annotate _handle_error_response as NoReturn Adds NoReturn type hint so type checkers know the method always raises, eliminating implicit None return warnings on callers. --- miniflux.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/miniflux.py b/miniflux.py index b5134e1..9d25c58 100644 --- a/miniflux.py +++ b/miniflux.py @@ -20,7 +20,7 @@ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN # THE SOFTWARE. -from typing import List, Optional, Union +from typing import List, NoReturn, Optional, Union import requests @@ -164,7 +164,7 @@ def _get_params(self, **kwargs) -> Optional[dict]: def _get_modification_params(self, **kwargs) -> dict: return {k: v for k, v in kwargs.items() if v is not None} - def _handle_error_response(self, response: requests.Response): + def _handle_error_response(self, response: requests.Response) -> NoReturn: if response.status_code == 404: raise ResourceNotFound(response) if response.status_code == 403: