The elevatedPerms is not used right now. Instead strings are used:
and the problem occurrence:
|
if (keyPermissions.includes('Administrator')) |
Expected Behavior
Strings can cause typos and this is not checked by IDE.
Current Behavior
Permission typos will not cause a 'squiggly line' in your IDE (yes in Javascript)
Possible Solution
Use the elevatedPerms as key-value object (not as array)
Steps to Reproduce (for bugs)
Not appl.
Context
Dev PR Review #105
The
elevatedPermsis not used right now. Instead strings are used:CharlieSpring/src/commands/fun/whois.js
Line 21 in ecb4a42
and the problem occurrence:
CharlieSpring/src/commands/fun/whois.js
Line 71 in ecb4a42
Expected Behavior
Strings can cause typos and this is not checked by IDE.
Current Behavior
Permission typos will not cause a 'squiggly line' in your IDE (yes in Javascript)
Possible Solution
Use the elevatedPerms as key-value object (not as array)
Steps to Reproduce (for bugs)
Not appl.
Context
Dev PR Review #105