From 49a6fe2c8c92405d39e066df15701207a90fadfb Mon Sep 17 00:00:00 2001 From: Cheng Date: Wed, 26 Aug 2026 19:10:25 +0900 Subject: [PATCH] Fix tests/run.py stuck in CI --- .github/actions/test-macos/action.yml | 2 +- .github/workflows/build_and_test.yml | 2 +- .github/workflows/release.yml | 2 +- python/tests/mlx_tests.py | 4 +--- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/actions/test-macos/action.yml b/.github/actions/test-macos/action.yml index 55e5acc5c5..aa043fb66c 100644 --- a/.github/actions/test-macos/action.yml +++ b/.github/actions/test-macos/action.yml @@ -47,7 +47,7 @@ runs: echo "::endgroup::" echo "::group::Run Python tests" - uv run python/tests/run.py -v + python -m unittest discover -v python/tests echo "::endgroup::" if ${{ inputs.toolkit != 'cpu' }} ; then diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index d590d10b12..a4b5ddf8f3 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -85,7 +85,7 @@ jobs: matrix: macos-target: ['14.0', '15.0', '26.2'] toolkit: ['cpu', 'metal', 'jit'] - runs-on: 'macos-26' + runs-on: 'macos-26-xlarge' needs: check_lint steps: - uses: actions/checkout@v7 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b53f003ff4..0445da0361 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -141,7 +141,7 @@ jobs: strategy: matrix: python-version: *pyver - runs-on: 'macos-26' + runs-on: 'macos-26-xlarge' env: *build-env steps: - uses: actions/checkout@v7 diff --git a/python/tests/mlx_tests.py b/python/tests/mlx_tests.py index 2b60f46154..84ccf51375 100644 --- a/python/tests/mlx_tests.py +++ b/python/tests/mlx_tests.py @@ -15,9 +15,7 @@ def __init__(self, *args, **kwargs): # Do not exit in runTests kwargs["exit"] = False super().__init__(*args, **kwargs) - - def runTests(self): - super().runTests() + # Do cleanup before exiting mx.clear_streams() sys.exit(0 if self.result.wasSuccessful() else 1)