fix(auth): align OAuth metadata discovery ordering#887
Open
jstar0 wants to merge 1 commit into
Open
Conversation
michaelneale
requested changes
Jun 9, 2026
michaelneale
left a comment
Contributor
There was a problem hiding this comment.
thanks @jstar0 from a brief reading of the spec: https://www.rfc-editor.org/info/rfc8414/#section-3.1 - then the tenant should be at the end, not before .well-known:
ie:
https://auth.example.com/.well-known/oauth-authorization-server/tenant1
not so much:
https://auth.example.com/tenant1/.well-known/oauth-authorization-server
I think, but otherwise looking good.
b387a7a to
2472e16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #878.
Summary
Changes
For a resource URL such as
https://example.com/mcp, the direct authorization-server discovery list is:https://example.com/.well-known/oauth-authorization-server/mcphttps://example.com/.well-known/openid-configuration/mcphttps://example.com/mcp/.well-known/openid-configurationhttps://example.com/.well-known/oauth-authorization-serverThe first three entries match the path-bearing issuer ordering from the MCP authorization spec. The existing canonical OAuth fallback remains last.
The client credentials regression now serves metadata at the RFC 8414 path-inserted OAuth endpoint, so the test exercises the same URL form as the candidate builder.
Verification