Skip to content
This repository was archived by the owner on Nov 11, 2019. It is now read-only.
This repository was archived by the owner on Nov 11, 2019. It is now read-only.

[shipit] Cancelling "promote" didn't cancel the underlying tasks #2234

Description

@mitchhentges

This might be related to #2226.
When I had double-promoted 69.0b9, I cancelled it so that I could do a fresh build.
Though the second promote was erroneous, I still expected one of the graph's tasks to be cancelled when I cancelled the promotion.

However, ship-it didn't cancel either graph when the promotion was cancelled.


I don't understand the bounds of this issue, but I'm reporting it so that we have context if we see the issue again

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions