JiJ ignores classifier

[USS-Shenzhou]

(Not sure if this repo is the right place to report it.)

I wrote this in my build.gradle:

    compileOnly(group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0")
    additionalRuntimeClasspath(group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0")
    jarJar(group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0")

    implementation group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0", classifier: "windows-x86_64"
    additionalRuntimeClasspath group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0", classifier: "windows-x86_64"
    jarJar(group: "dev.onvoid.webrtc", name: "webrtc-java", version: "0.14.0", classifier: "windows-x86_64")

And JiJ does not consider the classifier when packing jar, so 2 jars get the same identifier in metada.json:

    {
      "identifier": {
        "group": "dev.onvoid.webrtc",
        "artifact": "webrtc-java"
      },
      "version": {
        "range": "[0.14.0,)",
        "artifactVersion": "0.14.0"
      },
      "path": "META-INF/jarjar/webrtc-java-0.14.0.jar",
      "isObfuscated": false
    },
    {
      "identifier": {
        "group": "dev.onvoid.webrtc",
        "artifact": "webrtc-java"
      },
      "version": {
        "range": "[0.14.0,)",
        "artifactVersion": "0.14.0"
      },
      "path": "META-INF/jarjar/webrtc-java-0.14.0-windows-x86_64.jar",
      "isObfuscated": false
    },

So FML only recognizes the latter one:

[23:58:03] [main/INFO]: Found gamelibrary file "mixinextras-neoforge-0.5.0.jar" [parent: neoforge-21.8.51-universal.jar, locator: jarinjar, reader: mod manifest]
[23:58:03] [main/INFO]: Found library file "webrtc-java-0.14.0-windows-x86_64.jar" [parent: channel-0.1.0.jar, locator: jarinjar]
[23:58:03] [main/INFO]: Found library file "net.neoforged.neoforge-coremods-21.8.51.jar" [parent: neoforge-21.8.51-universal.jar, locator: jarinjar, reader: mod manifest]

[MUYUTwilighter]

Not sure if it's intended, but the trouble is raised by jarJar from ModDevGradle.

In JarJarArtifacts Line 104, only artifact group & name are used to create the identifier, so webrtc-java and webrtc-native with same group & name will be classified as "same" dependency, then one of them are excluded by neoforge during runtime of production environment.

For a temporary fix, you may misdirect jarJar by referencing dependency file locally so that neoforge would use module name as artifact name.

configurations {
    // Key Step 1
    webrtcNativeBundle {
        canBeResolved = true
        canBeConsumed = false
        transitive = false
    }
}

dependencies {
    // ...
    jarJar "dev.onvoid.webrtc:webrtc-java:${webrtc_version}"
    jarJar files(configurations.webrtcNativeBundle)  // Key Step 2, use local file reference

    runtimeOnly "dev.onvoid.webrtc:webrtc-java:${webrtc_version}"
    runtimeOnly "dev.onvoid.webrtc:webrtc-java:${webrtc_version}:windows-x86_64"
    additionalRuntimeClasspath "dev.onvoid.webrtc:webrtc-java:${webrtc_version}"
    additionalRuntimeClasspath "dev.onvoid.webrtc:webrtc-java:${webrtc_version}:windows-x86_64"
    webrtcNativeBundle "dev.onvoid.webrtc:webrtc-java:${webrtc_version}:windows-x86_64"
}

Interestingly, even though specific source code is not found, I reproduced the same problem in forge 1.20.1. So most likely, this would be a bug inherited by neoforge.

In addition, fabric works pretty fine with WebRTC as it includes classifier as dependency file in the metadata.json. The format is like group_name_classifier. So maybe neoforge may take similar formats like group:name:classifier as the identifier?