Unused var: netdata_repoconfig_url

[rawiriblundell]

I noticed while working on my most recent PR that netdata_repoconfig_url does not appear to be used.

I suspect it's intended to be used at the very least in install-opensuse.yml in this task:

    - name: Add repository configuration
      community.general.zypper_repository:
        name: "netdata-repoconfig"
        repo: "{{ netdata_repository_url }}{{ netdata_release_channel_normalized }}/opensuse/{{ netdata_opensuse_releasever }}/$basearch"
        state: present
        auto_import_keys: true

Note the repo line refers to netdata_repository_url. It should probably be this:

    - name: Add repository configuration
      community.general.zypper_repository:
        name: "netdata-repoconfig"
        repo: "{{ netdata_repoconfig_url }}{{ netdata_release_channel_normalized }}/opensuse/{{ netdata_opensuse_releasever }}/$basearch"
        state: present
        auto_import_keys: true

This appears to be evidence that netdata_repository_url and netdata_repoconfig_url are easy to confuse. Probably for cleanliness we could ditch netdata_repoconfig_url altogether and bring netdata_repository_url back to its root location i.e. https://repo.netdata.cloud

The above task would then look like this:

    - name: Add repository configuration
      community.general.zypper_repository:
        name: "netdata-repoconfig"
        repo: "{{ netdata_repository_url }}/repoconfig/{{ netdata_release_channel_normalized }}/opensuse/{{ netdata_opensuse_releasever }}/$basearch"
        state: present
        auto_import_keys: true