Skip to content

[stable32] fix: allow file request upload when part_file_in_storage=false - #63381

Merged
salmart-dev merged 1 commit into
stable32from
backport/62986/stable32
Aug 19, 2026
Merged

[stable32] fix: allow file request upload when part_file_in_storage=false#63381
salmart-dev merged 1 commit into
stable32from
backport/62986/stable32

Conversation

@salmart-dev

Copy link
Copy Markdown
Contributor

Backport of PR #62986

@salmart-dev salmart-dev self-assigned this Aug 18, 2026
@salmart-dev
salmart-dev requested a review from a team as a code owner August 18, 2026 12:42
@salmart-dev
salmart-dev requested review from Altahrim and icewind1991 and removed request for a team August 18, 2026 12:42
@salmart-dev salmart-dev added the 3. to review Waiting for reviews label Aug 18, 2026
@github-actions github-actions Bot changed the title fix: allow file request upload when part_file_in_storage=false [stable32] fix: allow file request upload when part_file_in_storage=false Aug 18, 2026
@joshtrichards

Copy link
Copy Markdown
Member

MariaDB 11.8 failure unrelated - #63401 will address it in the stable32 branch.

@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 19, 2026
@salmart-dev

Copy link
Copy Markdown
Contributor Author

Sorry, I accidentally clicked on "Fix with Copilot" and it committed. This is so annoying. I'll remove the commit manually.

@salmart-dev
salmart-dev force-pushed the backport/62986/stable32 branch from 3fc3ccf to fd1daa1 Compare August 19, 2026 09:01
The part_file_in_storage option being disabled, causes files to be
uploaded in the user's root, rather than in the final directory. This,
in combination with the use of upload nicknames, was not detected by the
patched check, causing uploads to check for the UPDATE permissions,
which is not granted for file requests, making all uploads always fail.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
@joshtrichards
joshtrichards force-pushed the backport/62986/stable32 branch from fd1daa1 to 0aaa20b Compare August 19, 2026 11:15
@salmart-dev
salmart-dev merged commit 6a8a259 into stable32 Aug 19, 2026
198 checks passed
@salmart-dev
salmart-dev deleted the backport/62986/stable32 branch August 19, 2026 14:14
@joshtrichards joshtrichards added this to the Nextcloud 32.0.15 milestone Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish 32-feedback bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants