test(files_sharing): cover sharing through multiple mounts - #63416
Open
joshtrichards wants to merge 1 commit into
Open
test(files_sharing): cover sharing through multiple mounts#63416joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Assisted-by: Copilot:gpt-5.6-terra Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
icewind1991 and
sorbaugh
and removed request for
a team
August 19, 2026 13:00
Member
Author
|
/backport to stable34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen coverage for sharing a node reachable through multiple mounts with different permissions.
The previous test did not create multiple accessible paths to the same node and injected
PERMISSION_ALLintoNodeResource, so it did not exercise permission merging. This version creates and accepts:It then verifies that
NodeResource::getNodePermissions()merges permissions across both paths and allows the share interaction.Follow-up to recently merged PR #63299 to improve regression coverage.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)