Skip to content

test(files_sharing): cover sharing through multiple mounts - #63416

Open
joshtrichards wants to merge 1 commit into
masterfrom
jtr/test-share-creation-thru-multiple-mounts
Open

test(files_sharing): cover sharing through multiple mounts#63416
joshtrichards wants to merge 1 commit into
masterfrom
jtr/test-share-creation-thru-multiple-mounts

Conversation

@joshtrichards

@joshtrichards joshtrichards commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

Strengthen coverage for sharing a node reachable through multiple mounts with different permissions.

The previous test did not create multiple accessible paths to the same node and injected PERMISSION_ALL into NodeResource, so it did not exercise permission merging. This version creates and accepts:

  • a full-permission parent-folder share
  • a read-only direct share of the child

It then verifies that NodeResource::getNodePermissions() merges permissions across both paths and allows the share interaction.

Follow-up to recently merged PR #63299 to improve regression coverage.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Assisted-by: Copilot:gpt-5.6-terra

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 35 milestone Aug 19, 2026
@joshtrichards
joshtrichards requested a review from a team as a code owner August 19, 2026 13:00
@joshtrichards
joshtrichards requested review from icewind1991 and sorbaugh and removed request for a team August 19, 2026 13:00
@joshtrichards

Copy link
Copy Markdown
Member Author

/backport to stable34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants