From de7043151d3137143218316add6f97fbc5a419d7 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 28 Aug 2026 15:09:21 +0000
Subject: [PATCH 1/2] Initial plan


From 0ead6b231ccb19ce2b5c2ca0cc768b42c35b2c84 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Fri, 28 Aug 2026 15:12:33 +0000
Subject: [PATCH 2/2] Update stock assessment citation style

Co-authored-by: Schiano-NOAA <125507018+Schiano-NOAA@users.noreply.github.com>
---
 inst/resources/cjfas.csl        | 44 ++++++++++++++-------------------
 tests/testthat/test-cjfas-csl.R | 26 +++++++++++++++++--
 2 files changed, 43 insertions(+), 27 deletions(-)

diff --git a/inst/resources/cjfas.csl b/inst/resources/cjfas.csl
index fef2782a..d211e1d3 100644
--- a/inst/resources/cjfas.csl
+++ b/inst/resources/cjfas.csl
@@ -51,28 +51,21 @@
     </names>
   </macro>
   <macro name="author-short">
-    <choose>
-      <if type="report" variable="genre" match="all">
-        <text variable="publisher"/>
-      </if>
-      <else>
-        <names variable="author">
-          <name form="short" and="text" delimiter=", " initialize-with=". "/>
-          <substitute>
-            <names variable="editor"/>
-            <names variable="translator"/>
-            <choose>
-              <if type="bill book graphic legal_case legislation motion_picture report song" match="any">
-                <text variable="title" form="short" font-style="italic"/>
-              </if>
-              <else>
-                <text variable="title" form="short" quotes="true"/>
-              </else>
-            </choose>
-          </substitute>
-        </names>
-      </else>
-    </choose>
+    <names variable="author">
+      <name form="short" and="text" delimiter=", " initialize-with=". "/>
+      <substitute>
+        <names variable="editor"/>
+        <names variable="translator"/>
+        <choose>
+          <if type="bill book graphic legal_case legislation motion_picture report song" match="any">
+            <text variable="title" form="short" font-style="italic"/>
+          </if>
+          <else>
+            <text variable="title" form="short" quotes="true"/>
+          </else>
+        </choose>
+      </substitute>
+    </names>
   </macro>
   <macro name="access">
     <choose>
@@ -251,10 +244,11 @@
       <choose>
         <if type="report" variable="genre" match="all">
           <group delimiter=". ">
-            <text variable="publisher"/>
-            <text macro="issued-month-year"/>
+            <text macro="author"/>
+            <text macro="issued-year"/>
             <text variable="title"/>
-            <text variable="publisher-place"/>
+            <text variable="publisher"/>
+            <text variable="number-of-pages" suffix=" p."/>
             <text macro="stock-assessment-access"/>
           </group>
         </if>
diff --git a/tests/testthat/test-cjfas-csl.R b/tests/testthat/test-cjfas-csl.R
index e54f4fe6..d272580d 100644
--- a/tests/testthat/test-cjfas-csl.R
+++ b/tests/testthat/test-cjfas-csl.R
@@ -8,7 +8,29 @@ test_that("cjfas CSL includes stock-assessment report formatting", {
   )
 
   expect_match(csl, '<if type="report" variable="genre" match="all">', fixed = TRUE)
-  expect_match(csl, '<text macro="issued-month-year"/>', fixed = TRUE)
+  expect_match(
+    csl,
+    paste(
+      c(
+        '<if type="report" variable="genre" match="all">',
+        '          <group delimiter=". ">',
+        '            <text macro="author"/>',
+        '            <text macro="issued-year"/>',
+        '            <text variable="title"/>',
+        '            <text variable="publisher"/>',
+        '            <text variable="number-of-pages" suffix=" p."/>',
+        '            <text macro="stock-assessment-access"/>'
+      ),
+      collapse = "\n"
+    ),
+    fixed = TRUE
+  )
   expect_match(csl, '<text value="Accessible at"/>', fixed = TRUE)
-  expect_match(csl, '<text variable="publisher"/>', fixed = TRUE)
+  expect_false(
+    grepl(
+      '<if type="report" variable="genre" match="all">\n        <text variable="publisher"/>',
+      csl,
+      fixed = TRUE
+    )
+  )
 })