Create new repository for stock synthesis automated workflows?

[k-doering-NOAA]

Kelli and I were chatting today and think it may be good to have one place for all Stock Synthesis workflows (github actions). In the past we have discussed this, but it was not really possible to implement wthout reusable workflows.

We propose having a repo in the nmfs-stock-synthesis org, perhaps called "workflows" or "ss3-workflows", that contain workflows that can be shared across our R packages, and across the different repositories in nmfs-stock-synthesis.

Does anyone have thoughts about this?

[Rick-Methot-NOAA]

What is an example of such a workflow? Is benefit/cost of such an effort clearly high?

[k-doering-NOAA]

Sure, here is a reusable workflow for checking R packages: https://github.com/k-doering-NOAA/reusable-workflows/blob/main/.github/workflows/r-cmd-check.yml

I set up SSMSE and r4ss to use it, which means less duplication: https://github.com/nmfs-fish-tools/SSMSE/blob/main/.github/workflows/call-r-cmd-check.yml and https://github.com/r4ss/r4ss/blob/main/.github/workflows/call-r-cmd-check.yml
ss3sim (and any R package) could also use the reusable workflow.

I think the benefit is it will be easier to update the workflows all at once and all the workflows will be in one place., in the same repo We can move the stock synthesis testing workflows here as well, so you and Ian have one place to look for the workflow files, rather than having to ask me where they live.

[kellijohnson-NOAA]

Kathryn and I discussed the best location for these workflow files and, because some of them are SS3 focused, we thought that it would be better to house them within "nmfs-stock-synthesis" rather than somewhere like FIT or a less-used organization such as under a personal GitHub account. Ideally, I see the number of workflow files growing in the future and, if they are stored in one central location, it makes it easier to ensure that r4ss, ss3sim, and SSMSE are all up to date with the best practices in a timely manner. We could in theory store all of the R-focused workflows in r4ss and call them from there but we thought this was less visible.

[Rick-Methot-NOAA]

Makes sense. Go for it.

…

On Tue, Nov 9, 2021 at 5:42 AM Kelli Johnson ***@***.***> wrote: Kathryn and I discussed the best location for these workflow files and, because some of them are SS3 focused, we thought that it would be better to house them within "nmfs-stock-synthesis" rather than somewhere like FIT or a less-used organization such as under a personal GitHub account. Ideally, I see the number of workflow files growing in the future and, if they are stored in one central location, it makes it easier to ensure that r4ss, ss3sim, and SSMSE are all up to date with the best practices in a timely manner. We could in theory store all of the R-focused workflows in r4ss and call them from there but we thought this was less visible. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/orgs/nmfs-stock-synthesis/teams/developers/discussions/9/comments/3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPV4IASUK2AXLGFXJNNXITULEQMFANCNFSM5HT2S4OA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[k-doering-NOAA]

Thanks @Rick-Methot-NOAA ! @kellijohnson-NOAA , could you create the repo? Unfortunately I don't have permissions to do it (NWFSC rules)

[kellijohnson-NOAA]

No problem, do you want "workflows" or "ss3-workflows"?

[Rick-Methot-NOAA]

I just created "workflows"

…

On Tue, Nov 9, 2021 at 9:14 AM Kelli Johnson ***@***.***> wrote: No problem, do you want "workflows" or "ss3-workflows"? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/orgs/nmfs-stock-synthesis/teams/developers/discussions/9/comments/6>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPV4IET7PVUYFIASPESWCLULFJFTANCNFSM5HT2S4OA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.