Skip to content

Commit 990649a

Browse files
committed
chore(pm): keep the dispatch-gates self-test's two end-to-end cards honest (#13919)
Wiring `check:swallow-census-controls` turns `measure-durability-swallow-family.mjs` into a GATE SCRIPT, so the convention KIND now hits it and it can no longer serve as the card where the block harvest and `--commands` must agree exactly. Repointed at `measure-partial-retirement-annotation.mjs` — the shape the census copied, which no check family runs. Also classifies the new `selfTestMode` argv parser in COMPOUND_ANCHOR_LEDGER as accidental, rather than renaming it to dodge the anchor.
1 parent 93aecd5 commit 990649a

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

scripts/pm/dispatch-gates.mjs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2316,6 +2316,7 @@ const COMPOUND_ANCHOR_LEDGER = [
23162316
['scripts/check-self-test-workflow-commands.mjs', 'runSelfTest', true],
23172317
['scripts/check-step-collectors.mjs', 'selfTestTargets', true],
23182318
['scripts/check-step-collectors.mjs', 'selfTestDiscoveries', true],
2319+
['scripts/measure-durability-swallow-family.mjs', 'selfTestMode', true],
23192320
['scripts/measure-self-test-floor.mjs', 'selfTestDefs', true],
23202321
['scripts/pm/dispatch-gates.mjs', 'selfTestOnlyCallables', true],
23212322
['scripts/pm/dispatch-gates.mjs', 'maskSelfTests', true],
@@ -15986,7 +15987,18 @@ function selfTest() {
1598615987
// anyone to pass — which is the whole defect. Only a real run can tell them
1598715988
// apart, and only a real run can measure the two REMEDIES against each other.
1598815989
{
15989-
const seamCard = 'scripts/measure-durability-swallow-family.mjs';
15990+
// The card has to be one NO convention KIND hits, so the only difference
15991+
// between the snippet's block harvest and `--commands` is the SPELLING
15992+
// split this pair measures; the strictly-better direction is driven
15993+
// separately, on `testCard` below, and conflating the two would leave
15994+
// neither measured. This was `measure-durability-swallow-family.mjs` until
15995+
// #13919 wired that instrument's controls as `check:swallow-census-controls`
15996+
// — which made it a GATE SCRIPT, so the "adds or edits a GATE SCRIPT"
15997+
// convention started hitting it and the two counts stopped agreeing for a
15998+
// reason that is not about spelling at all. ⛔ Do not repair a future
15999+
// recurrence by loosening the equality: repoint the card, and pick one that
16000+
// no check family runs.
16001+
const seamCard = 'scripts/measure-partial-retirement-annotation.mjs';
1599016002
const humanRun = runCli([seamCard]);
1599116003
const humanOut = humanRun.stdout ?? '';
1599216004
t('the seam card still derives at all', humanRun.status === 0 && humanOut.trim().length > 0);

0 commit comments

Comments
 (0)