Skip to content

plugin-auth: register-sso-provider emits two lowercase wire-visible error codes (request_domain_verification_failed, verify_domain_failed) — ADR-0112 violation invisible to the casing gate #10716

Description

@os-zhuang

Split out of #10658 at triage: that card fixes the GATE (the ||-fallback recognizer blindness in scripts/check-error-code-casing.mjs); this card fixes the two CODES it could not see. Different lane (plugin-auth = services), different risk (wire-visible rename), must not ride a tooling PR.

What

packages/plugins/plugin-auth/src/register-sso-provider.ts emits ObjectStack-authored default error codes in lowercase, as the fallback arm of an || chain:

line code
411 request_domain_verification_failed
465 verify_domain_failed

e.g. line 465: code: parsed?.code || 'verify_domain_failed'. The parsed?.code path is the vendor pass-through; the literal is ours. ADR-0112 / Prime Directive #3 require SCREAMING_SNAKE for our error codes. Measured at 47aff0938 (see #10658 for the positive control proving the gate misses this spelling).

Constraints for the fix

Filed by the triage seat; queue-ready (concrete lines, measured, mechanical edit + pin update).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions