Skip to content

.changeset/stack-refusal-envelopes.md still says "None of the six is registered in ERROR_CODE_LEDGER" — PR #16652 registers all six, and both changesets compile into the same release #16671

Description

@os-trump

Escalated to the seat by the at-tier contract review of PR #16652 (card #16449) and verified independently by the domain:spec seat on origin/main. ⛔ No domain:* set — routing is triage's.

Measured

.changeset/stack-refusal-envelopes.md:24 on origin/main, verbatim:

None of the six is registered in ERROR_CODE_LEDGER, for the reason the precedent was not: no wire door raises them …

That changeset is #16342's, pending release. PR #16652 registers all seven STACK_* codes (the six plus STACK_CROSS_REFERENCE_INVALID) in ERROR_CODE_LEDGER.

⇒ Both changesets are unconsumed in .changeset/ and compile into the same release, so the published CHANGELOG would carry a sentence that the same release falsifies.

Why this is worth a card rather than a note

⚠️ It has a hard deadline that is not a review deadline: once the release compiles, the sentence is fixed in a published CHANGELOG, and the repo's own rule is that release notes are written centrally at release time and ⛔ never amended per-PR afterwards. Before the release it is a one-line edit; after it, it is an erratum.

⭐ It is also the residue of a real process miss, worth recording next to the fix: #16342 landed at 1ecee3e537 without registering its six codes, although the #16404 ruling (decision batch #62, option D) required that PR to "either land its six registrations itself or land after this card". It did neither. The registration has now been done by #16652, but that changeset's prose was written on the assumption that it would not be.

Not a content/docs/releases/ edit — this is a .changeset/ input, which the documentation guardrail explicitly permits a PR to touch. A one-line amendment in a follow-up PR is the correct route; ⛔ do not fold it into #16652 mid-review.

Scope

One sentence in one file. Replace the "None of the six is registered" clause with the true statement (registered by #16652 under @objectstack/spec, with the reachability reading — no wire door raises them, so no HTTP body changes). ⚠️ Keep the surrounding "Not narrowed" paragraph intact: that part is still true and is the changeset's actual semver justification.

⚠️ Sequencing: after PR #16652 merges (before then the sentence is still true). If #16652 does not land before the release cuts, this card closes as premise-false instead.

Refs: PR #16652 · #16449 · #16342 · #16404 (the ruling) · the contract-review verdict on #16449 (5574180701).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions