From b32a50f07f3b91654961ed6c29070ae04a8efb0e Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 2 Sep 2026 14:55:34 +0000 Subject: [PATCH] fix(release): cut-rc.yml's hotcrm smoke warning no longer claims pre-exit re-arms the gate MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The step's warning string and its comment both keyed the gate's re-arm event to `changeset pre exit`, which release.yml's own comment records was superseded (#8643): pre-exit fired and the deadlock stood anyway, because a migrated hotcrm release did not exist yet. release.yml's gate now keys the same posture on shipping a migrated hotcrm release and bumping HOTCRM_REF (+ BLOCKING=1), and its warning already says so. This mirrors that wording into cut-rc.yml's warning and drops the "#3600 amendment" keying from the step comment in favor of the actual reason this lane's step is advisory: it has no BLOCKING switch and only ever runs in pre mode. No logic change — if:/env:/run: control flow and HOTCRM_REF are untouched, and release.yml is untouched. --- .github/workflows/cut-rc.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/cut-rc.yml b/.github/workflows/cut-rc.yml index dca1b20c0e..883b10f96e 100644 --- a/.github/workflows/cut-rc.yml +++ b/.github/workflows/cut-rc.yml @@ -866,11 +866,11 @@ jobs: echo "@objectstack/cli@$(jq -r '.version' packages/cli/package.json) is on main at ${LOCAL}." # Pre-publish gate #2035, kept in step with release.yml's publish job rather - # than dropped for speed. In pre mode (which the guard step proved is active, - # so ALWAYS on this lane) the #3600 amendment makes it advisory: a major - # train exists to ship deliberate surface removals, and a migrated hotcrm - # cannot exist until the rc artifacts it would migrate against are published. - # It reports; it cannot block. + # than dropped for speed. This step is advisory by construction — it has no + # BLOCKING switch — because this lane only ever runs in pre mode (the guard + # step above proved it active). It reports; it cannot block. For why the + # equivalent gate in release.yml is currently advisory too, and what re-arms + # it, see that step's own comment. - name: Downstream backward-compat smoke (live hotcrm, advisory in pre mode) if: ${{ !inputs.dry_run }} env: @@ -879,7 +879,7 @@ jobs: if bash scripts/downstream-smoke.sh; then echo "::notice::hotcrm@${HOTCRM_REF} is still compatible with the pre-release train." else - echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release and bump HOTCRM_REF in release.yml before 'changeset pre exit' re-arms that gate." + echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release, bump it, and set BLOCKING=1 in .github/workflows/release.yml to re-arm this gate." fi # ────────────────────────────────────────────────────────────────────────