plugin-form: EmbeddableForm 的「Redirecting in N seconds…」是一次性渲染的静态数字,整个等待期间不递减

[yinlianghui]

修 objectui#5073(PR #5082)时路过发现,未在该 PR 中修(#5073 的完成范围是「文案跟随裁定」,不含文案的动态性)。未指派。

事实

packages/plugin-form/src/EmbeddableForm.tsx 致谢面板的倒计时文案把秒数渲染一次就不再变:

• 模板 texts.redirecting ?? 'Redirecting in {{seconds}} seconds…'({{seconds}} 的文档说明是 "the remaining seconds")在渲染期做一次 Math.ceil(delayMs / 1000) 替换,组件里没有任何 setInterval / 逐秒 state,所以 3000ms 默认延迟下,提交者看到的是整整三秒钟纹丝不动的「Redirecting in 3 seconds…」,直到页面被换掉。
• 十个 locale 的 publicForm.redirecting 都是同一记法(将在 {{seconds}} 秒后跳转…、Redirecting in {{seconds}} seconds… 等),即这个「剩余秒数」的语义是全语言一致地声明出来的,只是没有人在减它。

PR #5082 之后该行只在目的地被接受时渲染(秒数取被接受目的地一同捕获的 delayMs),因此这条只剩「数字不动」这一点 —— 它在 #5082 前后都一样。

为什么按 observation 立(而不是 defect)

数字在渲染那一刻是准确的,等待也确实照这个时长走完,没有任何功能受影响;差别只是文案自称 "remaining" 却不 remaining。按「不动的秒数 vs 逐秒递减」这是打磨类,故打 finding、不打 pm:queue。

如果分诊认为「对公众说了一句随时间变假的话」属于用户可见的不准确(#5073 家族正是这个论证),请直接改判为 defect 并加 pm:queue —— 立卡时的严重度判断本就不可靠,这里只作平铺陈述。

若要修,形状

一个以被接受目的地为键的 setInterval(与 PR #5070 建立的「等待由组件持有」同一所有权模型:effect 拥有它,unmount 与 handleReset 各自取消),或者干脆把模板改成不承诺剩余量的说法。前者要注意别再造一个无人拥有的定时器 —— 那正是 #5049 修掉的东西。

[yinlianghui]

检索记录(避免重复立卡):按关键词与文件路径各查了一轮 open issues(EmbeddableForm / EmbeddableForm.tsx / 倒计时不递减 / frozen countdown / redirecting 文案),命中只有 #5073 本身,无同题卡片,故新立。未指派 —— 仅记录,不占坑。

补一句正文被 issues 端点截掉的收尾。

---

Generated by Claude Code

[os-support-ai]

Triage (first-touch, triage seat, session session_01HXzdkKx5WjwwCTT3c7U5kB): promoted finding → pm:queue, type Task — the public-form thank-you panel claims "remaining seconds" in 10 locales and never decrements; small, concrete, user-visible on a published surface.

Scope: either implement the countdown per the card's shape (interval keyed on the accepted destination, owned by the effect per PR #5070's ownership model — cancel on unmount and handleReset; do not recreate the unowned-timer defect #5049 removed), or change the template family to wording that doesn't promise a remaining count (that route touches all 10 locale packs). Dev's choice; the first is preferred since the locale strings already promise decrementing semantics.

Size/model suggestion: S, mode:subagent.

---

Generated by Claude Code

[os-support-ai]

Claim: PM loop round 14

Session: session_01RV6yuVCxymHYE16PL9vQkE
Branch: claude/issue-5083-embeddable-form-countdown
Worktree: objectui-issue-5083
Domain: repo:objectui
File surface: packages/plugin-form/src/** (EmbeddableForm and its tests); the 10 locale packs only if you take the wording route (stop on breach; explain in the report)
Container & model: S, mode:subagent, model: sonnet (taking the triage seat's suggestion)
Clause-②: no — no contract surface changes; this makes a rendered string tell the truth.
Serial constraints cleared: packages/plugin-form is free. In-flight PRs at claim time hold disjoint surfaces: PR #5290 apps/console, PR #5294 packages/plugin-view, PR #5295 .github/workflows + scripts/ + root manifests, PR #5297 packages/plugin-map, PR #5298 packages/components + packages/types, PR #5300 / #5303 packages/plugin-dashboard, PR #5302 packages/cli. Sibling dispatch this round is #4906 (packages/plugin-report) — disjoint.

Scope, per the triage ruling

The public-form thank-you panel promises "remaining seconds" in 10 locales and never decrements — a static number rendered once and left there for the whole wait.

Two routes; the first is preferred and the triage seat said why: the locale strings already promise decrementing semantics, so changing the copy would be retreating from a promise the product already makes.

1. Implement the countdown — interval keyed on the accepted destination, owned by the effect per PR fix(plugin-form): EmbeddableForm 的 thank-you redirect 等待改由组件持有,unmount 与「再填一份」均取消 (#5049) #5070's ownership model: cancel on unmount and on handleReset.
   ⛔ Do not recreate the unowned-timer defect that plugin-form: EmbeddableForm's thank-you redirect timer is unowned too — and its default 3s window fires into "Submit Another Response" #5049 removed. Read both before writing — this is a repo that has already paid for getting timer ownership wrong here.
2. Change the template family to wording that makes no numeric promise — touches all 10 locale packs.

Your choice, but justify it if you pick 2.

Verification

Re-derive on current origin/main first (the card is ~2 days old; note main just took the CI fix from #5304). Test that the number actually decreases over time — a test asserting only the initial render would pass against the current broken behaviour. Use fake timers; assert the interval is cleared on unmount and on handleReset (that's the #5049 regression surface).

Reverse-verify: revert the fix with tests kept, predict exactly which assertions go red and name them BEFORE running, then report predicted-vs-observed. Any assertion green on both legs pins nothing — say so rather than counting it. State whether a build artifact sits between your edit and the thing under test.

Changeset: patch on @object-ui/plugin-form. ⛔ NEVER declare major — objectui's major is pinned to @objectstack's major.
⛔ Do not edit content/docs/releases/, docs/adr/**, .claude/**, skills/**, AGENTS.md, CLAUDE.md.

---

Generated by Claude Code

[os-support-ai]

<!-- os-dev-report -->

{
  "issue": 5083,
  "status": "done",
  "branch": "claude/issue-5083-embeddable-form-countdown",
  "pr": "https://github.com/objectstack-ai/objectui/pull/5311",
  "premise_still_valid": true,
  "summary": "EmbeddableForm's thank-you countdown ('Redirecting in {{seconds}} seconds…') was computed once at render time and never decremented, confirmed by reading current EmbeddableForm.tsx on origin/main before editing. Took route 1 (implement the countdown, not reword) per the triage ruling: all 10 locale packs document {{seconds}} as 'remaining seconds'. Added packages/plugin-form/src/thankYouRedirectCountdown.ts (useRedirectCountdownSeconds), a per-second setInterval owned by an effect keyed on the accepted pendingRedirect destination, on the same ownership model PR #5070 established -- cancelled on unmount and on handleReset, the exact regression surface #5049 fixed; self-clears on reaching 0. EmbeddableForm.tsx now reads the ticking value instead of re-deriving delayMs once.",
  "tests": "No build artifact sits between the edit and the thing under test -- vitest transforms the .ts/.tsx source directly via Vite on every run; the separate `pnpm --filter build` runs below are correctness checks (bundling/dts), not a dependency of the test run. Commands (final HEAD 6029bdfa8, plugin-form worktree): `pnpm --filter '@object-ui/plugin-form^...' build` clean; `pnpm --filter @object-ui/plugin-form build` clean, no TS errors; `pnpm --filter @object-ui/plugin-form type-check` clean; `pnpm --filter @object-ui/plugin-form test` -> 574/574 passed (56 files), including 3 new cases in EmbeddableForm.redirectCountdownTick.test.tsx (fake timers, 4s delay, asserts 4->3->2->1->0 decrementing text, interval-armed spy, self-clear at 0, clearInterval on unmount, clearInterval on handleReset with a getByLabelText(/email/i) counter-probe pairing the 'no countdown' zero-assertion). eslint on the 3 changed/new files: 0 errors. node scripts/check-changeset-presence.mjs / check-changeset-no-major.mjs / check-changeset-fixed.mjs / check-control-bytes.mjs / check-lint-coverage.mjs / check-type-check-coverage.mjs: all green, plus a manual grep -naP control-byte self-scan (clean). Reverse-verification, predicted BEFORE running (recorded in the test file's own docblock): reverting EmbeddableForm.tsx only (to de4e29a81, one commit pre-fix) with tests kept would fail all 3 tests at `expect(armed.length).toBe(1)` (reverted code never calls setInterval), while the preceding 'Redirecting in 4 seconds' initial-render assertion would stay green (already correct pre-fix, demonstrating it alone pins nothing). Measured: exactly that -- all 3 tests failed with identical `AssertionError: expected +0 to be 1` at that line, nothing failed on the initial-render text. Restored the committed EmbeddableForm.tsx; all 3 return to green with no other change. Every zero-assertion in the new tests is paired with a known-present neighbouring term (stale-seconds-text absence paired with fresh-seconds-text presence; post-reset countdown absence paired with the fresh form's email label being present).",
  "open_questions": [],
  "out_of_scope_findings": []
}

---

Generated by Claude Code